From 83a68d04ae8e48846a01c3b7e53b829d9f116440 Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Fri, 11 Apr 2025 14:36:56 +0300 Subject: [PATCH] QmlDesigner: Fix invalid section caption on complex properties Custom generated sections for complex exposed local properties now show the proper section caption instead of default "Title". Fixes: QDS-15045 Change-Id: I9e4d5b9c7731eaecece16c6b187496748b755bee Reviewed-by: Mahmoud Badri --- .../components/componentcore/propertycomponentgenerator.cpp | 2 +- .../componentcore/propertycomponentgenerator-test.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/qmldesigner/components/componentcore/propertycomponentgenerator.cpp b/src/plugins/qmldesigner/components/componentcore/propertycomponentgenerator.cpp index 1b9e7c409e2..9c349f3dec6 100644 --- a/src/plugins/qmldesigner/components/componentcore/propertycomponentgenerator.cpp +++ b/src/plugins/qmldesigner/components/componentcore/propertycomponentgenerator.cpp @@ -128,7 +128,7 @@ QString PropertyComponentGenerator::generateComplexComponentText(Utils::SmallStr static QString templateText = QStringLiteral( R"xy( Section { - caption: %1 - %2 + caption: "%1 - %2" anchors.left: parent.left anchors.right: parent.right leftPadding: 8 diff --git a/tests/unit/tests/unittests/componentcore/propertycomponentgenerator-test.cpp b/tests/unit/tests/unittests/componentcore/propertycomponentgenerator-test.cpp index 2a5f5cd87e3..facce0fa5e9 100644 --- a/tests/unit/tests/unittests/componentcore/propertycomponentgenerator-test.cpp +++ b/tests/unit/tests/unittests/componentcore/propertycomponentgenerator-test.cpp @@ -223,7 +223,7 @@ TEST_F(PropertyComponentGenerator, QString expectedText = QStringLiteral( R"xy( Section { - caption: foo - Foo + caption: "foo - Foo" anchors.left: parent.left anchors.right: parent.right leftPadding: 8 @@ -256,7 +256,7 @@ TEST_F(PropertyComponentGenerator, QString expectedText = QStringLiteral( R"xy( Section { - caption: foo - Foo + caption: "foo - Foo" anchors.left: parent.left anchors.right: parent.right leftPadding: 8