forked from qt-creator/qt-creator
ProjectExplorer: Streamline OutputFormatter creation a bit
Note that the concept of a single monolithic OutputFormatter per RunConfiguration (and why RunConfiguration, not RunControl to start with?) is unchanged and suboptimal as one cannot easily combine existing use cases, e.g. Python_and_Qt. Change-Id: Ibeb8191020387324f22ed313230293597f96e36a Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
@@ -101,6 +101,8 @@ QbsRunConfiguration::QbsRunConfiguration(Target *target)
|
||||
addExtraAspect(new WorkingDirectoryAspect(this, "Qbs.RunConfiguration.WorkingDirectory"));
|
||||
addExtraAspect(new TerminalAspect(this, "Qbs.RunConfiguration.UseTerminal"));
|
||||
|
||||
setOutputFormatter<QtSupport::QtOutputFormatter>();
|
||||
|
||||
connect(project(), &Project::parsingFinished, this,
|
||||
[envAspect]() { envAspect->buildEnvironmentHasChanged(); });
|
||||
|
||||
@@ -176,11 +178,6 @@ void QbsRunConfiguration::addToBaseEnvironment(Utils::Environment &env) const
|
||||
m_envCache.insert(key, env);
|
||||
}
|
||||
|
||||
Utils::OutputFormatter *QbsRunConfiguration::createOutputFormatter() const
|
||||
{
|
||||
return new QtSupport::QtOutputFormatter(target()->project());
|
||||
}
|
||||
|
||||
void QbsRunConfiguration::updateTargetInformation()
|
||||
{
|
||||
BuildTargetInfo bti = target()->applicationTargets().buildTargetInfo(buildKey());
|
||||
|
||||
@@ -49,7 +49,6 @@ public:
|
||||
|
||||
QWidget *createConfigurationWidget() final;
|
||||
ProjectExplorer::Runnable runnable() const final;
|
||||
Utils::OutputFormatter *createOutputFormatter() const final;
|
||||
|
||||
void addToBaseEnvironment(Utils::Environment &env) const;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user