feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use QString::splitRef() instead of QString::split()

Browse Source 
Avoid string allocation where it seems feasible.

Change-Id: I61b23d4ef8a459f5aa77727a75f4e1d2b140da3b
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Friedemann Kleint
2016-11-23 10:10:55 +01:00
parent 90fb7c79d8
commit 840e787175
11 changed files with 27 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/debugger/cdb/cdbengine.cpp
View File

@@ -2071,7 +2071,7 @@ void CdbEngine::ensureUsing32BitStackInWow64(const DebuggerResponse &response, c
{
// Parsing the header of the stack output to check which bitness
// the cdb is currently using.
foreach (const QString &line, response.data.data().split('\n')) {
foreach (const QStringRef &line, response.data.data().splitRef(QLatin1Char('\n'))) {
if (!line.startsWith("Child"))
continue;
if (line.startsWith("ChildEBP")) {
@@ -2909,7 +2909,8 @@ void CdbEngine::setupScripting(const DebuggerResponse &response)
return;
}
const QString &verOutput = data.data();
const QStringList pythonVersion = verOutput.split(' ').first().split('.');
const QVector<QStringRef> pythonVersion =
verOutput.split(QLatin1Char(' ')).constFirst().splitRef(QLatin1Char('.'));
bool ok = false;
if (pythonVersion.size() == 3) {