feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SyntaxHighlighter: Make setChangeNumbers private function

Browse Source 
Made setChangeNumbers private function in BaseAnnotationHighlighter
and remove usage in other places.
Moved annotationChanges to BaseAnnotationHighlighterPrivate from
VcsBaseEditorWidget.
This was done to move all instances of TextEditor::SyntaxHighlighter.
In this regards only the public API of TextEditor::SyntaxHighlighter
should be available from children and no other additional functions.

Change-Id: Ibece9476a810e13c8722839820d5c575b0808f03
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Artem Sokolovskii
2023-05-19 13:03:01 +02:00
parent 6910408f35
commit 84275809b4
28 changed files with 156 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/cvs/cvseditor.cpp
View File

@@ -25,10 +25,10 @@ namespace Cvs::Internal {
class CvsAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighter
{
public:
explicit CvsAnnotationHighlighter(const ChangeNumbers &changeNumbers,
QTextDocument *document = nullptr) :
VcsBase::BaseAnnotationHighlighter(changeNumbers, document)
{ }
explicit CvsAnnotationHighlighter(const VcsBase::Annotation &annotation,
QTextDocument *document = nullptr)
: VcsBase::BaseAnnotationHighlighter(annotation, document)
{}
private:
QString changeNumber(const QString &block) const override
@@ -95,7 +95,7 @@ QString CvsEditorWidget::changeUnderCursor(const QTextCursor &c) const
VcsBase::BaseAnnotationHighlighterCreator CvsEditorWidget::annotationHighlighterCreator() const
{
return [](const QSet<QString> &changes) { return new CvsAnnotationHighlighter(changes); };
return VcsBase::getAnnotationHighlighterCreator<CvsAnnotationHighlighter>();
}
QStringList CvsEditorWidget::annotationPreviousVersions(const QString &revision) const