feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Fix incorrect checks

Browse Source 
There is no reason to force m_buffer = m_internal afaik.

Change-Id: I6cab375c9d416d4fbe167c4cfb884e7cc6025381
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-10-31 12:44:15 +01:00
parent e108726314
commit 845676f814
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libs/utils/aspects.cpp
View File

@@ -1794,8 +1794,6 @@ LayoutItem BoolAspect::adoptButton(QAbstractButton *button)
*/ */
void BoolAspect::addToLayout(Layouting::LayoutItem &parent) void BoolAspect::addToLayout(Layouting::LayoutItem &parent)
{ {
QTC_ASSERT(m_buffer == m_internal, m_buffer = m_internal);
QCheckBox *checkBox = createSubWidget<QCheckBox>(); QCheckBox *checkBox = createSubWidget<QCheckBox>();
addToLayoutHelper(parent, checkBox); addToLayoutHelper(parent, checkBox);
bufferToGui(); bufferToGui();
@@ -1903,7 +1901,6 @@ void SelectionAspect::addToLayout(Layouting::LayoutItem &parent)
QTC_CHECK(d->m_buttonGroup == nullptr); QTC_CHECK(d->m_buttonGroup == nullptr);
QTC_CHECK(!d->m_comboBox); QTC_CHECK(!d->m_comboBox);
QTC_ASSERT(d->m_buttons.isEmpty(), d->m_buttons.clear()); QTC_ASSERT(d->m_buttons.isEmpty(), d->m_buttons.clear());
QTC_ASSERT(m_buffer == m_internal, m_buffer = m_internal);
switch (d->m_displayStyle) { switch (d->m_displayStyle) {
case DisplayStyle::RadioButtons: case DisplayStyle::RadioButtons: