feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

C++: Better names for Scope's iterators

Browse Source 
Scope::lastMember() was misleading.

Change-Id: I953d489b8a2a9b86321f73cad3b7b371c4acf91f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
This commit is contained in:
Nikolai Kosjar
2015-01-13 17:29:34 +01:00
parent d9c70f43d9
commit 845cb2e432
8 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libs/3rdparty/cplusplus/Scope.cpp vendored
View File

@@ -238,7 +238,7 @@ Scope::Scope(Clone *clone, Subst *subst, Scope *original)
, _startOffset(original->_startOffset)
, _endOffset(original->_endOffset)
{
for (iterator it = original->firstMember(), end = original->lastMember(); it != end; ++it)
for (iterator it = original->memberBegin(), end = original->memberEnd(); it != end; ++it)
addMember(clone->symbol(*it, subst));
}
@@ -267,11 +267,11 @@ Symbol *Scope::memberAt(unsigned index) const
{ return _members ? _members->symbolAt(index) : 0; }
/// Returns the first Symbol in the scope.
Scope::iterator Scope::firstMember() const
Scope::iterator Scope::memberBegin() const
{ return _members ? _members->firstSymbol() : 0; }
/// Returns the last Symbol in the scope.
Scope::iterator Scope::lastMember() const
Scope::iterator Scope::memberEnd() const
{ return _members ? _members->lastSymbol() : 0; }
Symbol *Scope::find(const Identifier *id) const