feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify ProjectTree:aboutToShowContextMenu()

Browse Source 
Only one user that doesn't use one of the arguments.

Change-Id: I72c1360b23edf88e8de733542bde608f84d8de0b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-09-28 11:54:48 +02:00
parent 62e7d7eb49
commit 84bbab1c97
4 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/modeleditor/modelsmanager.cpp
View File

@@ -227,11 +227,8 @@ void ModelsManager::setDiagramClipboard(ExtDocumentController *documentControlle
emit diagramClipboardChanged(isDiagramClipboardEmpty()); emit diagramClipboardChanged(isDiagramClipboardEmpty());
} }
void ModelsManager::onAboutToShowContextMenu(ProjectExplorer::Project *project, void ModelsManager::onAboutToShowContextMenu(ProjectExplorer::Node *node)
ProjectExplorer::Node *node)
{ {
Q_UNUSED(project)
bool canOpenDiagram = false; bool canOpenDiagram = false;
foreach (const ManagedModel &managedModel, d->managedModels) { foreach (const ManagedModel &managedModel, d->managedModels) {

2
src/plugins/modeleditor/modelsmanager.h
View File

@@ -81,7 +81,7 @@ public:
const qmt::MContainer &mcontainer); const qmt::MContainer &mcontainer);
private: private:
void onAboutToShowContextMenu(ProjectExplorer::Project *project, ProjectExplorer::Node *node); void onAboutToShowContextMenu(ProjectExplorer::Node *node);
void onOpenDiagramFromProjectExplorer(); void onOpenDiagramFromProjectExplorer();
void onOpenDefaultModel(const qmt::Uid &modelUid); void onOpenDefaultModel(const qmt::Uid &modelUid);

3
src/plugins/projectexplorer/projecttree.cpp
View File

@@ -360,8 +360,7 @@ ProjectTreeWidget *ProjectTree::currentWidget() const
void ProjectTree::showContextMenu(ProjectTreeWidget *focus, const QPoint &globalPos, Node *node) void ProjectTree::showContextMenu(ProjectTreeWidget *focus, const QPoint &globalPos, Node *node)
{ {
QMenu *contextMenu = nullptr; QMenu *contextMenu = nullptr;
Project *project = projectForNode(node); emit s_instance->aboutToShowContextMenu(node);
emit s_instance->aboutToShowContextMenu(project, node);
if (!node) { if (!node) {
contextMenu = Core::ActionManager::actionContainer(Constants::M_SESSIONCONTEXT)->menu(); contextMenu = Core::ActionManager::actionContainer(Constants::M_SESSIONCONTEXT)->menu();

3
src/plugins/projectexplorer/projecttree.h
View File

@@ -102,8 +102,7 @@ signals:
// Emitted whenever the model needs to send a update signal. // Emitted whenever the model needs to send a update signal.
void subtreeChanged(ProjectExplorer::FolderNode *node); void subtreeChanged(ProjectExplorer::FolderNode *node);
void aboutToShowContextMenu(ProjectExplorer::Project *project, void aboutToShowContextMenu(ProjectExplorer::Node *node);
ProjectExplorer::Node *node);
// Emitted on any change to the tree // Emitted on any change to the tree
void treeChanged(); void treeChanged();