feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Initialize members

Browse Source 
m_toolbarDock was only initialized in finalizeSetup, which is triggered
by the plugin's initialize() method. This is not safe since Creator might
shut down before that method ever gets called.

Change-Id: Idadb6ac943ed6799d1bd9db1ecb884cb39038389
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Tobias Hunger
2016-12-05 13:43:45 +01:00
committed by hjk
parent 15cad7dec5
commit 85115d486a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/debugger/debuggermainwindow.h
View File

@@ -146,7 +146,7 @@ private:
QStackedWidget *m_centralWidgetStack; QStackedWidget *m_centralWidgetStack;
QWidget *m_editorPlaceHolder; QWidget *m_editorPlaceHolder;
Utils::StatusLabel *m_statusLabel; Utils::StatusLabel *m_statusLabel;
QDockWidget *m_toolbarDock; QDockWidget *m_toolbarDock = nullptr;
QHash<QByteArray, QDockWidget *> m_dockForDockId; QHash<QByteArray, QDockWidget *> m_dockForDockId;
QHash<QByteArray, QWidget *> m_toolbarForPerspectiveId; QHash<QByteArray, QWidget *> m_toolbarForPerspectiveId;