feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Remove parent pointer from IOptionPage constructor

Browse Source 
Not used anymore.

Change-Id: Ic44ce021b1f952337a3193454b5b6649d5847446
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2023-05-08 14:09:09 +02:00
parent bd660aaf27
commit 851f317199
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/coreplugin/dialogs/ioptionspage.cpp
View File

@@ -240,8 +240,7 @@ static QList<IOptionsPage *> g_optionsPages;
Constructs an options page with the given \a parent and registers it Constructs an options page with the given \a parent and registers it
at the global options page pool if \a registerGlobally is \c true. at the global options page pool if \a registerGlobally is \c true.
*/ */
IOptionsPage::IOptionsPage(QObject *parent, bool registerGlobally) IOptionsPage::IOptionsPage(bool registerGlobally)
: QObject(parent)
{ {
if (registerGlobally) if (registerGlobally)
g_optionsPages.append(this); g_optionsPages.append(this);

2
src/plugins/coreplugin/dialogs/ioptionspage.h
View File

@@ -42,7 +42,7 @@ class CORE_EXPORT IOptionsPage : public QObject
Q_OBJECT Q_OBJECT
public: public:
IOptionsPage(QObject *parent = nullptr, bool registerGlobally = true); explicit IOptionsPage(bool registerGlobally = true);
~IOptionsPage() override; ~IOptionsPage() override;
static const QList<IOptionsPage *> allOptionsPages(); static const QList<IOptionsPage *> allOptionsPages();

4
src/plugins/designer/settingspage.cpp
View File

@@ -34,8 +34,8 @@ public:
}; };
SettingsPage::SettingsPage(QDesignerOptionsPageInterface *designerPage) : SettingsPage::SettingsPage(QDesignerOptionsPageInterface *designerPage)
Core::IOptionsPage(nullptr, false) : Core::IOptionsPage(false)
{ {
setId(Utils::Id::fromString(designerPage->name())); setId(Utils::Id::fromString(designerPage->name()));
setDisplayName(designerPage->name()); setDisplayName(designerPage->name());