feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJS checks: Limit warning about unintentional empty blocks.

Browse Source 
width: {
    }

should not trigger a warning. We now only warn if { and } are
on the same line.

Change-Id: I45fa846ff63d0a83de782c412212165845c07e72
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
This commit is contained in:
Christian Kamm
2011-10-13 14:19:50 +02:00
parent 1868dd94f0
commit 8532e7b1b7
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libs/qmljs/qmljscheck.cpp
View File

@@ -935,8 +935,9 @@ bool Check::visit(Block *ast)
}
if (!ast->statements
&& (cast<UiPublicMember *>(p)
|| cast<UiScriptBinding *>(p))) {
addMessage(WarnUnintentinalEmptyBlock, ast->firstSourceLocation());
|| cast<UiScriptBinding *>(p))
&& ast->lbraceToken.startLine == ast->rbraceToken.startLine) {
addMessage(WarnUnintentinalEmptyBlock, locationFromRange(ast->firstSourceLocation(), ast->lastSourceLocation()));
}
}
return true;