From 85617f1369e2638d47c1b583650200bd4805ddb3 Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Thu, 16 May 2024 15:31:37 +0200 Subject: [PATCH] Git: Avoid crash when reloading files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Explicitly reset the document when the document gets closed. Task-number: QTCREATORBUG-30824 Change-Id: I4fb3d6fd6041990e5b8b4f6b7c4fd9ebc62f5a4a Reviewed-by: Orgad Shaneh Reviewed-by: André Hartmann --- src/plugins/git/instantblame.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/plugins/git/instantblame.cpp b/src/plugins/git/instantblame.cpp index 5921518c347..f932c78698e 100644 --- a/src/plugins/git/instantblame.cpp +++ b/src/plugins/git/instantblame.cpp @@ -166,6 +166,13 @@ void InstantBlame::setup() connect(EditorManager::instance(), &EditorManager::currentEditorChanged, this, setupBlameForEditor); + connect(EditorManager::instance(), &EditorManager::documentClosed, + this, [this](IDocument *doc) { + if (m_document != doc) + return; + disconnect(m_documentChangedConn); + m_document = nullptr; + }); } // Porcelain format of git blame output