feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Cleanup StringCache

Browse Source 
There is now a forward header and it is possible template the string type.

Change-Id: Ibebd32c475a2d89a90da7190e77d44278eb43740
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2017-08-17 15:24:11 +02:00
parent 09206ba0e4
commit 8617f497bc
5 changed files with 217 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

83
tests/unit/unittest/stringcache-test.cpp
View File

@@ -31,7 +31,8 @@
namespace {
using testing::ElementsAre;
using ClangBackEnd::StringCacheEntries;
using ClangBackEnd::StringCacheException;
class StringCache : public testing::Test
{
@@ -125,4 +126,84 @@ TEST_F(StringCache, AddFilePaths)
ASSERT_THAT(ids, ElementsAre(0, 1, 2, 3));
}
TEST_F(StringCache, IsEmpty)
{
auto isEmpty = cache.isEmpty();
ASSERT_TRUE(isEmpty);
}
TEST_F(StringCache, IsNotEmpty)
{
cache.stringId(filePath1);
auto isEmpty = cache.isEmpty();
ASSERT_FALSE(isEmpty);
}
TEST_F(StringCache, PopulateWithEmptyVector)
{
StringCacheEntries<Utils::PathString> entries;
cache.uncheckedPopulate(std::move(entries));
ASSERT_TRUE(cache.isEmpty());
}
TEST_F(StringCache, IsNotEmptyAfterPopulateWithSomeEntries)
{
StringCacheEntries<Utils::PathString> entries{{filePath1.clone(), 0},
{filePath2.clone(), 1},
{filePath3.clone(), 2},
{filePath4.clone(), 3}};
cache.uncheckedPopulate(std::move(entries));
ASSERT_TRUE(!cache.isEmpty());
}
TEST_F(StringCache, GetEntryAfterPopulateWithSomeEntries)
{
StringCacheEntries<Utils::PathString> entries{{filePath1.clone(), 0},
{filePath2.clone(), 1},
{filePath3.clone(), 2},
{filePath4.clone(), 3}};
cache.uncheckedPopulate(std::move(entries));
auto string = cache.string(2);
ASSERT_THAT(string, filePath3);
}
TEST_F(StringCache, EntriesHaveUniqueIds)
{
StringCacheEntries<Utils::PathString> entries{{filePath1.clone(), 0},
{filePath2.clone(), 1},
{filePath3.clone(), 2},
{filePath4.clone(), 2}};
ASSERT_THROW(cache.populate(std::move(entries)), StringCacheException);
}
TEST_F(StringCache, IdsAreHigherLowerEntriesSize)
{
StringCacheEntries<Utils::PathString> entries{{filePath1.clone(), 0},
{filePath2.clone(), 1},
{filePath3.clone(), 4},
{filePath4.clone(), 3}};
ASSERT_THROW(cache.populate(std::move(entries)), std::out_of_range);
}
TEST_F(StringCache, MultipleEntries)
{
StringCacheEntries<Utils::PathString> entries{{filePath1.clone(), 0},
{filePath1.clone(), 1},
{filePath3.clone(), 2},
{filePath4.clone(), 3}};
ASSERT_THROW(cache.populate(std::move(entries)), StringCacheException);
}
}