feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Create common base for IEditorFactory and IExternalEditor

Browse Source 
As preparation for both being selectable as default editor type for a
mime type.

Change-Id: Ie34ad25caa7fe0cc0b740c96743db9bab378bf24
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2021-11-02 14:22:17 +01:00
parent 5e77303b57
commit 862c969441
8 changed files with 93 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/qmakeprojectmanager/externaleditors.cpp
View File

@@ -99,12 +99,12 @@ static const char linguistDisplayName[] = QT_TRANSLATE_NOOP("OpenWith::Editors",
ExternalQtEditor::ExternalQtEditor(Utils::Id id,
const QString &displayName,
const QString &mimetype,
const CommandForQtVersion &commandForQtVersion) :
m_mimeTypes(mimetype),
m_id(id),
m_displayName(displayName),
m_commandForQtVersion(commandForQtVersion)
const CommandForQtVersion &commandForQtVersion)
: m_commandForQtVersion(commandForQtVersion)
{
setId(id);
setDisplayName(displayName);
setMimeTypes({mimetype});
}
ExternalQtEditor *ExternalQtEditor::createLinguistEditor()
@@ -127,21 +127,6 @@ ExternalQtEditor *ExternalQtEditor::createDesignerEditor()
}
}
QStringList ExternalQtEditor::mimeTypes() const
{
return m_mimeTypes;
}
Utils::Id ExternalQtEditor::id() const
{
return m_id;
}
QString ExternalQtEditor::displayName() const
{
return m_displayName;
}
static QString findFirstCommand(QVector<QtSupport::BaseQtVersion *> qtVersions,
ExternalQtEditor::CommandForQtVersion command)
{