feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: crash fix

Browse Source 
It was a very stupid idea to call QApplication::processEvents(); here
to avoid hickups.

The processEvents() forces the whole designDocumentController managment to be
be reentrant which it clearly is not (and should not be).
The reason is simply that resetView is called from there.
Adding a "flag" for the processEvents is also not a reasonable option.
This was just very bad style.
So I remove it.

Task-number: QTCREATORBUG-7120
Change-Id: I111cf9421f63b9ce44488f0d274624ff48777cef
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
This commit is contained in:
Thomas Hartmann
2012-03-16 11:30:58 +01:00
parent 72e3038629
commit 86487d8250
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/qmldesigner/components/propertyeditor/propertyeditor.cpp
View File

@@ -224,7 +224,6 @@ void PropertyEditor::NodeType::setup(const QmlObjectNode &fxObjectNode, const QS
m_contextObject->setSpecificsUrl(qmlSpecificsFile); m_contextObject->setSpecificsUrl(qmlSpecificsFile);
m_contextObject->setStateName(stateName); m_contextObject->setStateName(stateName);
QApplication::processEvents();
if (!fxObjectNode.isValid()) if (!fxObjectNode.isValid())
return; return;
ctxt->setContextProperty("propertyCount", QVariant(fxObjectNode.modelNode().properties().count())); ctxt->setContextProperty("propertyCount", QVariant(fxObjectNode.modelNode().properties().count()));