ProjectExplorer: Remove IDevice::terminalCommand

Since Terminals can now be started for device file paths, there
is no need anymore for IDevice::terminalCommand.

Change-Id: I01c831ea7ee29d53efa6880631e8c6d54a4316aa
Reviewed-by: Cristian Adam <cristian.adam@qt.io>

src/plugins/docker/dockerdevice.cpp

@@ -1240,17 +1240,4 @@ std::optional<FilePath> DockerDevice::clangdExecutable() const
     return d->clangdExecutable();
 }
 
-std::optional<Utils::CommandLine> DockerDevice::terminalCommand(const FilePath &workDir,
-                                                                const Environment &env) const
-{
-    Q_UNUSED(env)
-    const QString shell = d->environment().value_or("SHELL", "/bin/sh");
-    return d->withDockerExecCmd({FilePath::fromUserInput(shell), {}},
-                                std::nullopt,
-                                workDir,
-                                true,
-                                false,
-                                true);
-}
-
 } // namespace Docker::Internal

src/plugins/docker/dockerdevice.h

@@ -101,9 +101,6 @@ public:
     bool prepareForBuild(const ProjectExplorer::Target *target) override;
     std::optional<Utils::FilePath> clangdExecutable() const override;
 
-    std::optional<Utils::CommandLine> terminalCommand(const Utils::FilePath &workDir,
-                                                      const Utils::Environment &env) const override;
-
 protected:
     void fromMap(const QVariantMap &map) final;
     QVariantMap toMap() const final;