feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove IDevice::terminalCommand

Browse Source 
Since Terminals can now be started for device file paths, there
is no need anymore for IDevice::terminalCommand.

Change-Id: I01c831ea7ee29d53efa6880631e8c6d54a4316aa
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-03-01 09:57:43 +01:00
parent 517400e7f6
commit 86da87d306
10 changed files with 56 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/terminal/terminalwidget.cpp
View File

@@ -105,8 +105,8 @@ void TerminalWidget::setupPty()
m_process->setProcessMode(ProcessMode::Writer);
m_process->setTerminalMode(TerminalMode::Pty);
m_process->setCommand(shellCommand);
m_process->setWorkingDirectory(
m_openParameters.workingDirectory.value_or(FilePath::fromString(QDir::homePath())));
if (m_openParameters.workingDirectory.has_value())
m_process->setWorkingDirectory(*m_openParameters.workingDirectory);
m_process->setEnvironment(env);
connect(m_process.get(), &QtcProcess::readyReadStandardOutput, this, [this] {
@@ -122,8 +122,6 @@ void TerminalWidget::setupPty()
connect(m_process.get(), &QtcProcess::done, this, [this] {
m_cursor.visible = false;
if (m_process) {
onReadyRead();
if (m_process->exitCode() != 0) {
QByteArray msg = QString("\r\n\033[31mProcess exited with code: %1")
.arg(m_process->exitCode())