feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use const'ref in theses methods

Browse Source 
Change-Id: Idfa5ffdcf23d1ef80442276690b8082b8279dbfa
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Montel Laurent
2017-04-14 10:12:30 +02:00
committed by Laurent Montel
parent c60103fc66
commit 86ea365a0b
27 changed files with 46 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/cplusplus/MatchingText.cpp
View File

@@ -107,7 +107,7 @@ static bool insertQuote(const QChar ch, const BackwardsScanner &tk)
&& stringLiteralPrefixes.contains(tk.text(index));
}
static int countSkippedChars(const QString blockText, const QString &textToProcess)
static int countSkippedChars(const QString &blockText, const QString &textToProcess)
{
int skippedChars = 0;
const int length = qMin(blockText.length(), textToProcess.length());

6
src/libs/qmleditorwidgets/easingpane/easingcontextpane.cpp
View File

@@ -87,7 +87,7 @@ public:
m_sequential->resume();
}
}
void animate(int duration, QEasingCurve curve) {
void animate(int duration, const QEasingCurve &curve) {
reset();
m_sequential = new QSequentialAnimationGroup;
connect(m_sequential,&QAbstractAnimation::finished,this,&EasingSimulation::finished);
@@ -288,7 +288,7 @@ void QmlEditorWidgets::EasingContextPane::on_durationSpinBox_valueChanged(int ne
emit propertyChanged(QLatin1String("duration"), newValue);
}
void QmlEditorWidgets::EasingContextPane::on_easingShapeComboBox_currentIndexChanged(QString newShape)
void QmlEditorWidgets::EasingContextPane::on_easingShapeComboBox_currentIndexChanged(const QString &newShape)
{
if (newShape==QLatin1String("Linear"))
setLinear();
@@ -312,7 +312,7 @@ void QmlEditorWidgets::EasingContextPane::on_easingShapeComboBox_currentIndexCha
}
}
void QmlEditorWidgets::EasingContextPane::on_easingExtremesComboBox_currentIndexChanged(QString newExtremes)
void QmlEditorWidgets::EasingContextPane::on_easingExtremesComboBox_currentIndexChanged(const QString &newExtremes)
{
if (m_easingGraph->easingExtremes() != newExtremes) {
m_easingGraph->setEasingExtremes(newExtremes);

12
src/libs/qmleditorwidgets/easingpane/easingcontextpane.h
View File

@@ -74,12 +74,12 @@ private:
private slots:
void on_playButton_clicked();
void on_overshootSpinBox_valueChanged(double );
void on_periodSpinBox_valueChanged(double );
void on_amplitudeSpinBox_valueChanged(double );
void on_easingExtremesComboBox_currentIndexChanged(QString );
void on_easingShapeComboBox_currentIndexChanged(QString );
void on_durationSpinBox_valueChanged(int );
void on_overshootSpinBox_valueChanged(double);
void on_periodSpinBox_valueChanged(double);
void on_amplitudeSpinBox_valueChanged(double);
void on_easingExtremesComboBox_currentIndexChanged(const QString &);
void on_easingShapeComboBox_currentIndexChanged(const QString &);
void on_durationSpinBox_valueChanged(int);
void switchToGraph();
};

4
src/libs/qmljs/qmljsimportdependencies.cpp
View File

@@ -58,7 +58,7 @@ ImportKind::Enum toImportKind(ImportType::Enum type)
return ImportKind::Invalid;
}
ImportMatchStrength::ImportMatchStrength(QList<int> match)
ImportMatchStrength::ImportMatchStrength(const QList<int> &match)
: m_match(match)
{ }
@@ -482,7 +482,7 @@ Export::Export()
: intrinsic(false)
{ }
Export::Export(ImportKey exportName, QString pathRequired, bool intrinsic, const QString &typeName)
Export::Export(ImportKey exportName, const QString &pathRequired, bool intrinsic, const QString &typeName)
: exportName(exportName), pathRequired(pathRequired), typeName(typeName), intrinsic(intrinsic)
{ }

4
src/libs/qmljs/qmljsimportdependencies.h
View File

@@ -56,7 +56,7 @@ class QMLJS_EXPORT ImportMatchStrength
{
public:
explicit ImportMatchStrength() {}
ImportMatchStrength(QList<int> match);
ImportMatchStrength(const QList<int> &match);
int compareMatch(const ImportMatchStrength &o) const;
@@ -127,7 +127,7 @@ class QMLJS_EXPORT Export
public:
static QString libraryTypeName();
Export();
Export(ImportKey exportName, QString pathRequired, bool intrinsic = false,
Export(ImportKey exportName, const QString &pathRequired, bool intrinsic = false,
const QString &typeName = libraryTypeName());
ImportKey exportName;
QString pathRequired;

2
src/libs/qmljs/qmljslineinfo.h
View File

@@ -94,7 +94,7 @@ protected:
{
public:
Program() {}
Program(QTextBlock begin, QTextBlock end)
Program(const QTextBlock &begin, const QTextBlock &end)
: begin(begin), end(end) {}
QTextBlock firstBlock() const { return begin; }

2
src/libs/qmljs/qmljsviewercontext.cpp
View File

@@ -39,7 +39,7 @@ ViewerContext::ViewerContext()
: language(Dialect::Qml), flags(AddAllPaths)
{ }
ViewerContext::ViewerContext(QStringList selectors, QStringList paths,
ViewerContext::ViewerContext(const QStringList &selectors, const QStringList &paths,
QmlJS::Dialect language,
QmlJS::ViewerContext::Flags flags)
: selectors(selectors), paths(paths), language(language),

2
src/libs/qmljs/qmljsviewercontext.h
View File

@@ -44,7 +44,7 @@ public:
};
ViewerContext();
ViewerContext(QStringList selectors, QStringList paths,
ViewerContext(const QStringList &selectors, const QStringList &paths,
Dialect language = Dialect::Qml,
Flags flags = AddAllPaths);

14
src/libs/utils/filesearch.cpp
View File

@@ -85,7 +85,7 @@ class FileSearch
{
public:
FileSearch(const QString &searchTerm, QTextDocument::FindFlags flags,
QMap<QString, QString> fileToContentsMap);
const QMap<QString, QString> &fileToContentsMap);
void operator()(QFutureInterface<FileSearchResultList> &futureInterface,
const FileIterator::Item &item) const;
@@ -105,7 +105,7 @@ class FileSearchRegExp
{
public:
FileSearchRegExp(const QString &searchTerm, QTextDocument::FindFlags flags,
QMap<QString, QString> fileToContentsMap);
const QMap<QString, QString> &fileToContentsMap);
FileSearchRegExp(const FileSearchRegExp &other);
void operator()(QFutureInterface<FileSearchResultList> &futureInterface,
const FileIterator::Item &item) const;
@@ -119,7 +119,7 @@ private:
};
FileSearch::FileSearch(const QString &searchTerm, QTextDocument::FindFlags flags,
QMap<QString, QString> fileToContentsMap)
const QMap<QString, QString> &fileToContentsMap)
{
this->fileToContentsMap = fileToContentsMap;
caseSensitive = (flags & QTextDocument::FindCaseSensitively);
@@ -225,7 +225,7 @@ void FileSearch::operator()(QFutureInterface<FileSearchResultList> &futureInterf
}
FileSearchRegExp::FileSearchRegExp(const QString &searchTerm, QTextDocument::FindFlags flags,
QMap<QString, QString> fileToContentsMap)
const QMap<QString, QString> &fileToContentsMap)
{
this->fileToContentsMap = fileToContentsMap;
QString term = searchTerm;
@@ -360,7 +360,7 @@ void cleanUpFileSearch(QFutureInterface<FileSearchResultList> &futureInterface,
} // namespace
QFuture<FileSearchResultList> Utils::findInFiles(const QString &searchTerm, FileIterator *files,
QTextDocument::FindFlags flags, QMap<QString, QString> fileToContentsMap)
QTextDocument::FindFlags flags, const QMap<QString, QString> &fileToContentsMap)
{
return mapReduce(files->begin(), files->end(),
[searchTerm, files](QFutureInterface<FileSearchResultList> &futureInterface) {
@@ -372,7 +372,7 @@ QFuture<FileSearchResultList> Utils::findInFiles(const QString &searchTerm, File
}
QFuture<FileSearchResultList> Utils::findInFilesRegExp(const QString &searchTerm, FileIterator *files,
QTextDocument::FindFlags flags, QMap<QString, QString> fileToContentsMap)
QTextDocument::FindFlags flags, const QMap<QString, QString> &fileToContentsMap)
{
return mapReduce(files->begin(), files->end(),
[searchTerm, files](QFutureInterface<FileSearchResultList> &futureInterface) {
@@ -585,7 +585,7 @@ FileIterator::const_iterator FileIterator::end() const
// #pragma mark -- FileListIterator
QTextCodec *encodingAt(const QList<QTextCodec *> encodings, int index)
QTextCodec *encodingAt(const QList<QTextCodec *> &encodings, int index)
{
if (index >= 0 && index < encodings.size())
return encodings.at(index);

8
src/libs/utils/filesearch.h
View File

@@ -170,9 +170,9 @@ class QTCREATOR_UTILS_EXPORT FileSearchResult
{
public:
FileSearchResult() {}
FileSearchResult(QString fileName, int lineNumber, QString matchingLine,
FileSearchResult(const QString &fileName, int lineNumber, const QString &matchingLine,
int matchStart, int matchLength,
QStringList regexpCapturedTexts)
const QStringList &regexpCapturedTexts)
: fileName(fileName),
lineNumber(lineNumber),
matchingLine(matchingLine),
@@ -192,10 +192,10 @@ public:
typedef QList<FileSearchResult> FileSearchResultList;
QTCREATOR_UTILS_EXPORT QFuture<FileSearchResultList> findInFiles(const QString &searchTerm, FileIterator *files,
QTextDocument::FindFlags flags, QMap<QString, QString> fileToContentsMap = QMap<QString, QString>());
QTextDocument::FindFlags flags, const QMap<QString, QString> &fileToContentsMap = QMap<QString, QString>());
QTCREATOR_UTILS_EXPORT QFuture<FileSearchResultList> findInFilesRegExp(const QString &searchTerm, FileIterator *files,
QTextDocument::FindFlags flags, QMap<QString, QString> fileToContentsMap = QMap<QString, QString>());
QTextDocument::FindFlags flags, const QMap<QString, QString> &fileToContentsMap = QMap<QString, QString>());
QTCREATOR_UTILS_EXPORT QString expandRegExpReplacement(const QString &replaceText, const QStringList &capturedTexts);
QTCREATOR_UTILS_EXPORT QString matchCaseReplacement(const QString &originalText, const QString &replaceText);

2
src/plugins/coreplugin/basefilewizardfactory.h
View File

@@ -58,7 +58,7 @@ public:
explicit WizardDialogParameters(const QString &defaultPath, Id platform,
const QSet<Id> &requiredFeatures, DialogParameterFlags flags,
QVariantMap extraValues)
const QVariantMap &extraValues)
: m_defaultPath(defaultPath),
m_selectedPlatform(platform),
m_requiredFeatures(requiredFeatures),

2
src/plugins/coreplugin/find/highlightscrollbar.cpp
View File

@@ -128,7 +128,7 @@ void HighlightScrollBar::setPriority(Id category, HighlightScrollBar::Priority p
m_overlay->scheduleUpdate();
}
void HighlightScrollBar::addHighlights(Id category, QSet<int> highlights)
void HighlightScrollBar::addHighlights(Id category, const QSet<int> &highlights)
{
if (!m_overlay)
return;

2
src/plugins/coreplugin/find/highlightscrollbar.h
View File

@@ -59,7 +59,7 @@ public:
void setPriority(Id category, Priority prio);
void addHighlight(Id category, int highlight);
void addHighlights(Id category, QSet<int> highlights);
void addHighlights(Id category, const QSet<int> &highlights);
void removeHighlights(Id id);
void removeAllHighlights();

2
src/plugins/coreplugin/iwizardfactory.cpp
View File

@@ -159,7 +159,7 @@ QWidget *s_currentWizard = nullptr;
class NewItemDialogData
{
public:
void setData(const QString t, const QList<IWizardFactory *> f,
void setData(const QString &t, const QList<IWizardFactory *> &f,
const QString &dl, const QVariantMap &ev)
{
QTC_ASSERT(!hasData(), return);

2
src/plugins/projectexplorer/buildmanager.cpp
View File

@@ -462,7 +462,7 @@ void BuildManager::nextStep()
}
}
bool BuildManager::buildQueueAppend(QList<BuildStep *> steps, QStringList names, const QStringList &preambleMessage)
bool BuildManager::buildQueueAppend(const QList<BuildStep *> &steps, QStringList names, const QStringList &preambleMessage)
{
if (!d->m_running) {
d->m_outputWindow->clearContents();

2
src/plugins/projectexplorer/buildmanager.h
View File

@@ -95,7 +95,7 @@ private:
static void startBuildQueue();
static void nextStep();
static void clearBuildQueue();
static bool buildQueueAppend(QList<BuildStep *> steps, QStringList names, const QStringList &preambleMessage = QStringList());
static bool buildQueueAppend(const QList<BuildStep *> &steps, QStringList names, const QStringList &preambleMessage = QStringList());
static void incrementActiveBuildSteps(BuildStep *bs);
static void decrementActiveBuildSteps(BuildStep *bs);
static void disconnectOutput(BuildStep *bs);

2
src/plugins/projectexplorer/projectexplorer.h
View File

@@ -72,7 +72,7 @@ public:
class OpenProjectResult
{
public:
OpenProjectResult(QList<Project *> projects, QList<Project *> alreadyOpen,
OpenProjectResult(const QList<Project *> &projects, const QList<Project *> &alreadyOpen,
const QString &errorMessage)
: m_projects(projects), m_alreadyOpen(alreadyOpen),
m_errorMessage(errorMessage)

4
src/plugins/projectexplorer/sessiondialog.cpp
View File

@@ -38,14 +38,14 @@ namespace Internal {
class SessionValidator : public QValidator
{
public:
SessionValidator(QObject *parent, QStringList sessions);
SessionValidator(QObject *parent, const QStringList &sessions);
void fixup(QString & input) const;
QValidator::State validate(QString & input, int & pos) const;
private:
QStringList m_sessions;
};
SessionValidator::SessionValidator(QObject *parent, QStringList sessions)
SessionValidator::SessionValidator(QObject *parent, const QStringList &sessions)
: QValidator(parent), m_sessions(sessions)
{
}

2
src/plugins/projectexplorer/settingsaccessor.cpp
View File

@@ -139,7 +139,7 @@ public:
private:
struct TargetDescription
{
TargetDescription(QString tid, QString dn) :
TargetDescription(const QString &tid, const QString &dn) :
id(tid),
displayName(dn)
{

2
src/plugins/projectexplorer/target.cpp
View File

@@ -474,7 +474,7 @@ QIcon Target::overlayIcon() const
return d->m_overlayIcon;
}
void Target::setOverlayIcon(QIcon icon)
void Target::setOverlayIcon(const QIcon &icon)
{
d->m_overlayIcon = icon;
emit overlayIconChanged();

2
src/plugins/projectexplorer/target.h
View File

@@ -97,7 +97,7 @@ public:
QIcon icon() const;
QIcon overlayIcon() const;
void setOverlayIcon(QIcon icon);
void setOverlayIcon(const QIcon &icon);
QString overlayIconToolTip();
QVariantMap toMap() const override;

2
src/plugins/projectexplorer/taskwindow.cpp
View File

@@ -209,7 +209,7 @@ public:
QList<QAction *> m_actions;
};
static QToolButton *createFilterButton(QIcon icon, const QString &toolTip,
static QToolButton *createFilterButton(const QIcon &icon, const QString &toolTip,
QObject *receiver, std::function<void(bool)> lambda)
{
auto button = new QToolButton;

2
src/plugins/texteditor/colorpreviewhoverhandler.cpp
View File

@@ -44,7 +44,7 @@ namespace TextEditor {
* Qt::GlobalColor types (although there cannot be any spaces such as
* "Qt:: yellow")
*/
static QString extractColorString(const QString s, int pos)
static QString extractColorString(const QString &s, int pos)
{
if (s.length() < 3 || pos < 0 || pos >= s.length())
return QString();

2
src/plugins/texteditor/tabsettings.cpp
View File

@@ -312,7 +312,7 @@ QString TabSettings::indentationString(int startColumn, int targetColumn, int pa
return s;
}
void TabSettings::indentLine(QTextBlock block, int newIndent, int padding) const
void TabSettings::indentLine(const QTextBlock &block, int newIndent, int padding) const
{
const QString text = block.text();
const int oldBlockLength = text.size();

2
src/plugins/texteditor/tabsettings.h
View File

@@ -74,7 +74,7 @@ public:
int indentationColumn(const QString &text) const;
static int maximumPadding(const QString &text);
void indentLine(QTextBlock block, int newIndent, int padding = 0) const;
void indentLine(const QTextBlock &block, int newIndent, int padding = 0) const;
void reindentLine(QTextBlock block, int delta) const;
bool isIndentationClean(const QTextBlock &block, const int indent) const;

2
src/plugins/texteditor/typingsettings.cpp
View File

@@ -80,7 +80,7 @@ bool TypingSettings::equals(const TypingSettings &ts) const
&& m_smartBackspaceBehavior == ts.m_smartBackspaceBehavior;
}
bool TypingSettings::tabShouldIndent(const QTextDocument *document, QTextCursor cursor, int *suggestedPosition) const
bool TypingSettings::tabShouldIndent(const QTextDocument *document, const QTextCursor &cursor, int *suggestedPosition) const
{
if (m_tabKeyBehavior == TabNeverIndents)
return false;

2
src/plugins/texteditor/typingsettings.h
View File

@@ -56,7 +56,7 @@ public:
TypingSettings();
bool tabShouldIndent(const QTextDocument *document, QTextCursor cursor, int *suggestedPosition) const;
bool tabShouldIndent(const QTextDocument *document, const QTextCursor &cursor, int *suggestedPosition) const;
void toSettings(const QString &category, QSettings *s) const;
void fromSettings(const QString &category, const QSettings *s);