feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Cleanup QBS plugin

Browse Source 
Remove comments & debug messages.

Change-Id: Idcc03867e188de6fe258758b3d2cce22f1a1b732
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
BogDan Vatra
2019-06-15 10:13:03 +03:00
committed by BogDan Vatra
parent 30e863b676
commit 8728057f15
1 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/qbsprojectmanager/qbsnodes.cpp
View File

@@ -403,9 +403,6 @@ QString QbsProductNode::buildKey() const
QVariant QbsProductNode::data(Core::Id role) const QVariant QbsProductNode::data(Core::Id role) const
{ {
// if (role == Android::Constants::AndroidExtraLibs)
// return value("ANDROID_EXTRA_LIBS");
if (role == Android::Constants::AndroidDeploySettingsFile) { if (role == Android::Constants::AndroidDeploySettingsFile) {
for (const auto &artifact : m_qbsProductData.generatedArtifacts()) { for (const auto &artifact : m_qbsProductData.generatedArtifacts()) {
if (artifact.fileTags().contains("qt_androiddeployqt_input")) if (artifact.fileTags().contains("qt_androiddeployqt_input"))
@@ -419,11 +416,9 @@ QVariant QbsProductNode::data(Core::Id role) const
for (const auto &artifact : m_qbsProductData.generatedArtifacts()) { for (const auto &artifact : m_qbsProductData.generatedArtifacts()) {
if (artifact.fileTags().contains("dynamiclibrary")) { if (artifact.fileTags().contains("dynamiclibrary")) {
ret << QFileInfo(artifact.filePath()).path(); ret << QFileInfo(artifact.filePath()).path();
qDebug() << artifact.properties().toString();
} }
} }
ret.removeDuplicates(); ret.removeDuplicates();
qDebug() << ret;
return ret; return ret;
} }
@@ -435,16 +430,8 @@ QVariant QbsProductNode::data(Core::Id role) const
return {}; return {};
} }
if (role == Android::Constants::AndroidApk) { if (role == Android::Constants::AndroidApk)
// qDebug() << m_qbsProductData.name() << m_qbsProductData.targetExecutable() << m_qbsProductData.properties();
// for (const auto &artifact : m_qbsProductData.installableArtifacts()) {
// qDebug() << artifact.fileTags() << artifact.filePath();
// }
// for (const auto &artifact : m_qbsProductData.generatedArtifacts()) {
// qDebug() << artifact.fileTags() << artifact.filePath();
// }
return m_qbsProductData.targetExecutable(); return m_qbsProductData.targetExecutable();
}
return {}; return {};
} }