From 87d1865f99bdf818749dd894d44e623551d0800d Mon Sep 17 00:00:00 2001
From: David Schulz <david.schulz@qt.io>
Date: Tue, 13 Jun 2023 08:24:25 +0200
Subject: [PATCH] Copilot: ignore invalid or empty suggestions

Change-Id: I6765814ec74b456ad1bb1392472d9d488357582e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
---
 src/plugins/copilot/copilotclient.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/plugins/copilot/copilotclient.cpp b/src/plugins/copilot/copilotclient.cpp
index f935210b53d..790596a3c29 100644
--- a/src/plugins/copilot/copilotclient.cpp
+++ b/src/plugins/copilot/copilotclient.cpp
@@ -180,7 +180,11 @@ void CopilotClient::handleCompletions(const GetCompletionRequest::Response &resp
         return;
 
     if (const std::optional<GetCompletionResponse> result = response.result()) {
-        QList<Completion> completions = result->completions().toListOrEmpty();
+        auto isValidCompletion = [](const Completion &completion) {
+            return completion.isValid() && !completion.text().trimmed().isEmpty();
+        };
+        const QList<Completion> completions = Utils::filtered(result->completions().toListOrEmpty(),
+                                                              isValidCompletion);
         if (completions.isEmpty())
             return;
         editor->insertSuggestion(