feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: FilePath::setFromString microoptimizations

Browse Source 
Mostly relevant for debug builds.

Change-Id: I3d3789d5ef535afbb87339a75bed076cd548dda3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
hjk
2022-07-29 08:38:35 +02:00
parent 1d0f553ac5
commit 87e156fc41
1 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/libs/utils/filepath.cpp
View File

@@ -1137,46 +1137,48 @@ void FilePath::setFromString(const QString &filename)
{
#ifndef UTILS_FILEPATH_USE_REGEXP
static const QLatin1String qtcDevSlash("__qtc_devices__/");
static const QLatin1String slashDotSlash("/./");
static const QLatin1String colonSlashSlash("://");
static const QString rootPath = QDir::rootPath();
const QChar slash('/');
const QStringView fileNameView(filename);
const QString rootPath = QDir::rootPath();
if (fileNameView.startsWith(rootPath, Qt::CaseInsensitive)) { // Absolute path ...
const QStringView withoutRootPath = fileNameView.mid(rootPath.size());
if (withoutRootPath.startsWith(qtcDevSlash)) { // Starts with "/__qtc_devices__/" ...
const QStringView withoutQtcDeviceRoot = withoutRootPath.mid(qtcDevSlash.size());
const auto firstSlash = withoutQtcDeviceRoot.indexOf('/');
const auto firstSlash = withoutQtcDeviceRoot.indexOf(slash);
if (firstSlash != -1) {
m_scheme = withoutQtcDeviceRoot.left(firstSlash).toString();
const auto secondSlash = withoutQtcDeviceRoot.indexOf('/', firstSlash + 1);
const auto secondSlash = withoutQtcDeviceRoot.indexOf(slash, firstSlash + 1);
m_host = withoutQtcDeviceRoot.mid(firstSlash + 1, secondSlash - firstSlash - 1)
.toString();
if (secondSlash != -1) {
const QStringView path = withoutQtcDeviceRoot.mid(secondSlash);
m_data = path.startsWith(QLatin1String("/./")) ? path.mid(3).toString()
: path.toString();
return;
m_data = path.startsWith(slashDotSlash) ? path.mid(3).toString()
: path.toString();
} else {
m_data = slash;
}
m_data = "/";
return;
} else {
m_scheme.clear();
m_host.clear();
m_data = filename;
}
m_scheme = "";
m_host = "";
m_data = filename;
return;
}
}
const auto firstSlash = filename.indexOf('/');
const auto schemeEnd = filename.indexOf("://");
const auto firstSlash = filename.indexOf(slash);
const auto schemeEnd = filename.indexOf(colonSlashSlash);
if (schemeEnd != -1 && schemeEnd < firstSlash) {
// This is a pseudo Url, we can't use QUrl here sadly.
m_scheme = filename.left(schemeEnd);
const auto hostEnd = filename.indexOf('/', schemeEnd + 3);
const auto hostEnd = filename.indexOf(slash, schemeEnd + 3);
m_host = filename.mid(schemeEnd + 3, hostEnd - schemeEnd - 3);
m_data = filename.mid(hostEnd);