feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

speed up of cdb debugging helper initialization

Browse Source 
The symbols in gdbhelpers.dll are never namespaced.
Thus we don't have to resolve the symbols - we already know their names.
The resolution took 5 seconds per symbol on my machine.
This commit is contained in:
Joerg Bornemann
2010-07-21 11:02:04 +02:00
parent 1730141fe6
commit 8858e47de7
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/debugger/cdb/cdbdumperhelper.cpp
View File

@@ -435,10 +435,19 @@ static inline bool getSymbolAddress(CIDebugSymbols *sg,
bool CdbDumperHelper::initResolveSymbols(QString *errorMessage) bool CdbDumperHelper::initResolveSymbols(QString *errorMessage)
{ {
// Resolve the symbols we need (potentially namespaced). // Resolve the symbols we need.
// There is a 'qDumpInBuffer' in QtCore as well. // There is a 'qDumpInBuffer' in QtCore as well.
if (loadDebug) if (loadDebug)
qDebug() << Q_FUNC_INFO; qDebug() << Q_FUNC_INFO;
#if 1
// Symbols in the debugging helpers are never namespaced.
// Keeping the old code for now. ### maybe use as fallback?
const QString dumperModuleName = QLatin1String(dumperModuleNameC);
m_dumpObjectSymbol = dumperModuleName + QLatin1String("!qDumpObjectData440");
QString inBufferSymbol = dumperModuleName + QLatin1String("!qDumpInBuffer");
QString outBufferSymbol = dumperModuleName + QLatin1String("!qDumpOutBuffer");
bool rc;
#else
m_dumpObjectSymbol = QLatin1String("*qDumpObjectData440"); m_dumpObjectSymbol = QLatin1String("*qDumpObjectData440");
QString inBufferSymbol = QLatin1String("*qDumpInBuffer"); QString inBufferSymbol = QLatin1String("*qDumpInBuffer");
QString outBufferSymbol = QLatin1String("*qDumpOutBuffer"); QString outBufferSymbol = QLatin1String("*qDumpOutBuffer");
@@ -448,6 +457,7 @@ bool CdbDumperHelper::initResolveSymbols(QString *errorMessage)
&& resolveSymbol(m_coreEngine->interfaces().debugSymbols, dumperModuleName, &outBufferSymbol, errorMessage) == ResolveSymbolOk; && resolveSymbol(m_coreEngine->interfaces().debugSymbols, dumperModuleName, &outBufferSymbol, errorMessage) == ResolveSymbolOk;
if (!rc) if (!rc)
return false; return false;
#endif
// Determine buffer addresses, sizes and alloc buffer // Determine buffer addresses, sizes and alloc buffer
rc = getSymbolAddress(m_coreEngine->interfaces().debugSymbols, inBufferSymbol, &m_inBufferAddress, &m_inBufferSize, errorMessage) rc = getSymbolAddress(m_coreEngine->interfaces().debugSymbols, inBufferSymbol, &m_inBufferAddress, &m_inBufferSize, errorMessage)
&& getSymbolAddress(m_coreEngine->interfaces().debugSymbols, outBufferSymbol, &m_outBufferAddress, &m_outBufferSize, errorMessage); && getSymbolAddress(m_coreEngine->interfaces().debugSymbols, outBufferSymbol, &m_outBufferAddress, &m_outBufferSize, errorMessage);