feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Pass dialog parent to Utils::* file dialog

Browse Source 
Amends 3edc5673b5.

Turns out quite a few potential uses have other parents than
ICore::dialogParent().

Use a nullptr parent to mean ICore::dialogParent() to keep the
caller side simple.

Change-Id: Icfe1daafd710ae273d286679e0c8e2a3a27da552
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2021-08-11 09:01:53 +02:00
parent 7726267d07
commit 8885ef7e5a
10 changed files with 44 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/vcsbase/vcsbaseplugin.cpp
View File

@@ -644,7 +644,7 @@ void VcsBasePluginPrivate::createRepository()
// Prompt for a directory that is not under version control yet
QWidget *mw = ICore::dialogParent();
do {
directory = FileUtils::getExistingDirectory(tr("Choose Repository Directory"), directory);
directory = FileUtils::getExistingDirectory(nullptr, tr("Choose Repository Directory"), directory);
if (directory.isEmpty())
return;
const IVersionControl *managingControl = VcsManager::findVersionControlForDirectory(directory);