ProjectExplorer: Do not set run config display names unnecessarily

... when restoring a target.
The run configuration may not have its default display name yet, in
which case all but the first restored run configuration would get a
number as its display name.

Fixes: QTCREATORBUG-23123
Change-Id: I5068cb85b67166357e0a88fb9638131a24e1340f
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2019-11-07 14:01:28 +01:00
parent eebf36adc7
commit 88b4d44c50

View File

@@ -409,9 +409,13 @@ void Target::addRunConfiguration(RunConfiguration *rc)
// Check that we don't have a configuration with the same displayName
QString configurationDisplayName = rc->displayName();
QStringList displayNames = Utils::transform(d->m_runConfigurations, &RunConfiguration::displayName);
configurationDisplayName = Utils::makeUniquelyNumbered(configurationDisplayName, displayNames);
if (!configurationDisplayName.isEmpty()) {
QStringList displayNames = Utils::transform(d->m_runConfigurations,
&RunConfiguration::displayName);
configurationDisplayName = Utils::makeUniquelyNumbered(configurationDisplayName,
displayNames);
rc->setDisplayName(configurationDisplayName);
}
d->m_runConfigurations.push_back(rc);