feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppTools: Minor cleanup in completion tests

Browse Source 
* Remove superfluous dot from test file name
* Reuse an existing member

Change-Id: I735dee09ae7ceef4509a4bda87118baaf4d11b01
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
This commit is contained in:
Orgad Shaneh
2015-10-06 22:27:05 +03:00
committed by Orgad Shaneh
parent 7fa6d51942
commit 88c5b47e53
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/cpptools/cppcompletion_test.cpp
View File

@@ -78,7 +78,7 @@ public:
// Write source to file // Write source to file
m_temporaryDir.reset(new Tests::TemporaryDir()); m_temporaryDir.reset(new Tests::TemporaryDir());
QVERIFY(m_temporaryDir->isValid()); QVERIFY(m_temporaryDir->isValid());
const QByteArray fileExt = isObjC ? ".mm" : ".h"; const QByteArray fileExt = isObjC ? "mm" : "h";
const QString fileName = m_temporaryDir->createFile("file." + fileExt, m_source); const QString fileName = m_temporaryDir->createFile("file." + fileExt, m_source);
QVERIFY(!fileName.isEmpty()); QVERIFY(!fileName.isEmpty());
@@ -111,7 +111,7 @@ public:
languageFeatures.objCEnabled = false; languageFeatures.objCEnabled = false;
CppCompletionAssistInterface *ai CppCompletionAssistInterface *ai
= new CppCompletionAssistInterface(m_editorWidget->textDocument()->filePath().toString(), = new CppCompletionAssistInterface(m_editorWidget->textDocument()->filePath().toString(),
m_editorWidget->document(), m_position, m_textDocument, m_position,
ExplicitlyInvoked, m_snapshot, ExplicitlyInvoked, m_snapshot,
ProjectPart::HeaderPaths(), ProjectPart::HeaderPaths(),
languageFeatures); languageFeatures);
@@ -129,7 +129,7 @@ public:
const int pos = proposal.d->basePosition(); const int pos = proposal.d->basePosition();
const int length = m_position - pos; const int length = m_position - pos;
const QString prefix = Convenience::textAt(QTextCursor(m_editorWidget->document()), pos, const QString prefix = Convenience::textAt(QTextCursor(m_textDocument), pos,
length); length);
if (!prefix.isEmpty()) if (!prefix.isEmpty())
listmodel->filter(prefix); listmodel->filter(prefix);