Valgrind: Merge MemCheckRunner and ValgrindRunner base

It's mostly the xml/log handling, which can be re-used in other tools.

The change is purely mechanical, including some style fixes and
some modernization.

Change-Id: I6b44ae71451e8d3e26df40b9af9b4ec70038a92d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/valgrind/valgrindtestrunnertest.h

@@ -26,20 +26,15 @@
 
 #pragma once
 
+#include "xmlprotocol/error.h"
+
 #include <QObject>
 #include <QStringList>
 
-#include "xmlprotocol/error.h"
-
 namespace Valgrind {
 
-namespace XmlProtocol {
-class ThreadedParser;
-}
-
-namespace Memcheck {
-class MemcheckRunner;
-}
+namespace XmlProtocol { class ThreadedParser; }
+class ValgrindRunner;
 
 namespace Test {
 
@@ -77,8 +72,8 @@ private slots:
 private:
     QString runTestBinary(const QString &binary, const QStringList &vArgs = QStringList());
 
-    XmlProtocol::ThreadedParser *m_parser = 0;
-    Memcheck::MemcheckRunner *m_runner = 0;
+    XmlProtocol::ThreadedParser *m_parser = nullptr;
+    ValgrindRunner *m_runner = nullptr;
     QList<QByteArray> m_logMessages;
     QList<XmlProtocol::Error> m_errors;
     bool m_expectCrash = false;