From 898a7cbc882c29c99c50428d049dad1f48c81a07 Mon Sep 17 00:00:00 2001 From: Marco Bubke Date: Thu, 1 Jun 2023 20:27:13 +0200 Subject: [PATCH] QmlDesigner: Make more classes final Because the interface is for dependency injection only the implementation should be always final. Change-Id: I069126d8767b0e1072c1e938acb42086abed4a1e Reviewed-by: Tim Jenssen Reviewed-by: Reviewed-by: Burak Hancerli --- .../designercore/projectstorage/projectstorageupdater.h | 2 +- .../qmldesigner/designercore/projectstorage/qmldocumentparser.h | 2 +- .../qmldesigner/designercore/projectstorage/qmltypesparser.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/qmldesigner/designercore/projectstorage/projectstorageupdater.h b/src/plugins/qmldesigner/designercore/projectstorage/projectstorageupdater.h index 22778ac932a..519d11a920a 100644 --- a/src/plugins/qmldesigner/designercore/projectstorage/projectstorageupdater.h +++ b/src/plugins/qmldesigner/designercore/projectstorage/projectstorageupdater.h @@ -32,7 +32,7 @@ class ProjectStorage; class QmlDocumentParserInterface; class QmlTypesParserInterface; -class ProjectStorageUpdater : public ProjectStoragePathWatcherNotifierInterface +class ProjectStorageUpdater final : public ProjectStoragePathWatcherNotifierInterface { public: using PathCache = SourcePathCache, NonLockingMutex>; diff --git a/src/plugins/qmldesigner/designercore/projectstorage/qmldocumentparser.h b/src/plugins/qmldesigner/designercore/projectstorage/qmldocumentparser.h index 2896d54ebe7..96f28a4585f 100644 --- a/src/plugins/qmldesigner/designercore/projectstorage/qmldocumentparser.h +++ b/src/plugins/qmldesigner/designercore/projectstorage/qmldocumentparser.h @@ -12,7 +12,7 @@ namespace QmlDesigner { template class SourcePathCache; -class QmlDocumentParser : public QmlDocumentParserInterface +class QmlDocumentParser final : public QmlDocumentParserInterface { public: using ProjectStorage = QmlDesigner::ProjectStorage; diff --git a/src/plugins/qmldesigner/designercore/projectstorage/qmltypesparser.h b/src/plugins/qmldesigner/designercore/projectstorage/qmltypesparser.h index c1d9a3a0d45..6fcf82a2bb2 100644 --- a/src/plugins/qmldesigner/designercore/projectstorage/qmltypesparser.h +++ b/src/plugins/qmldesigner/designercore/projectstorage/qmltypesparser.h @@ -18,7 +18,7 @@ class ProjectStorage; template class SourcePathCache; -class QmlTypesParser : public QmlTypesParserInterface +class QmlTypesParser final : public QmlTypesParserInterface { public: using ProjectStorage = QmlDesigner::ProjectStorage;