feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Move .useTerminal modification to central fixup

Browse Source 
Even if this is LLDB-specific having the value fixed early
will help in moving terminal handling into a RunWorker
of its own.

Change-Id: I73a9564148dec9b28557c12cc248a4f0b668f8d7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2017-09-05 15:30:12 +02:00
parent 27e740cab4
commit 898eb4a460
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/debugger/debuggerruncontrol.cpp
View File

@@ -708,6 +708,13 @@ static bool fixupParameters(DebuggerRunParameters &rp, RunControl *runControl, Q
}
}
// FIXME: We can't handle terminals yet.
if (rp.useTerminal && rp.cppEngineType == LldbEngineType) {
qWarning("Run in Terminal is not supported yet with the LLDB backend");
m_errors.append(DebuggerPlugin::tr("Run in Terminal is not supported with the LLDB backend."));
rp.useTerminal = false;
}
return true;
}

7
src/plugins/debugger/lldb/lldbengine.cpp
View File

@@ -176,13 +176,6 @@ void LldbEngine::abortDebugger()
void LldbEngine::setupEngine()
{
// FIXME: We can't handle terminals yet.
if (runParameters().useTerminal) {
qWarning("Run in Terminal is not supported yet with the LLDB backend");
showMessage(tr("Run in Terminal is not supported with the LLDB backend."), AppError);
runParameters().useTerminal = false;
}
if (runParameters().useTerminal) {
QTC_CHECK(false); // See above.
if (HostOsInfo::isWindowsHost()) {