feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: Contruct CommonSettings on first access

Browse Source 
Change-Id: Ifa425e2f1952017769accd855e33d1fa53b7b6c9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2023-07-18 12:14:21 +02:00
parent 1042323e8c
commit 89a64a19e8
3 changed files with 27 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/vcsbase/vcsplugin.cpp
View File

@@ -40,7 +40,7 @@ public:
explicit VcsPluginPrivate(VcsPlugin *plugin)
: q(plugin)
{
QObject::connect(&m_settings, &AspectContainer::changed,
QObject::connect(&commonSettings(), &AspectContainer::changed,
[this] { slotSettingsChanged(); });
slotSettingsChanged();
}
@@ -57,7 +57,7 @@ public:
void populateNickNameModel()
{
QString errorMessage;
if (!NickNameDialog::populateModelFromMailCapFile(m_settings.nickNameMailMap(),
if (!NickNameDialog::populateModelFromMailCapFile(commonSettings().nickNameMailMap(),
m_nickNameModel,
&errorMessage)) {
qWarning("%s", qPrintable(errorMessage));
@@ -71,7 +71,6 @@ public:
}
VcsPlugin *q;
CommonVcsSettings m_settings;
QStandardItemModel *m_nickNameModel = nullptr;
};