feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Python: Do not remove unreachable interpreter on startup

Browse Source 
A device might be not reachable at Qt Creator startup so do not filter
out remote python interpreters after loading the settings.

Change-Id: I3ac4f2baaca882e699f2210f6f5a92523891b0ca
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2022-10-17 12:34:38 +02:00
parent ef476e538f
commit 89e90f31f1
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/python/pythonsettings.cpp
View File

@@ -835,9 +835,13 @@ void PythonSettings::initFromSettings(QSettings *settings)
m_interpreters << interpreter; m_interpreters << interpreter;
} }
m_interpreters = Utils::filtered(m_interpreters, [](const Interpreter &interpreter){ const auto keepInterpreter = [](const Interpreter &interpreter) {
return !interpreter.autoDetected || interpreter.command.isExecutableFile(); return !interpreter.autoDetected // always keep user added interpreters
}); || interpreter.command.needsDevice() // remote devices might not be reachable at startup
|| interpreter.command.isExecutableFile();
};
m_interpreters = Utils::filtered(m_interpreters, keepInterpreter);
m_defaultInterpreterId = settings->value(defaultKey).toString(); m_defaultInterpreterId = settings->value(defaultKey).toString();