feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix allocating potential far too much memory in the debugger.

Browse Source 
Beware of negative sizes.
This commit is contained in:
dt
2009-08-28 17:19:42 +02:00
parent 75ade29466
commit 8a3e02a9e4
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/debugger/cdb/cdbsymbolgroupcontext.cpp
View File

@@ -709,8 +709,9 @@ int CdbSymbolGroupContext::dumpQString(CIDebugDataSpaces *ds, WatchData *wd)
if (truncated) if (truncated)
size = maxLength; size = maxLength;
const QChar doubleQuote = QLatin1Char('"'); const QChar doubleQuote = QLatin1Char('"');
QString value(doubleQuote); QString value;
if (size) { if (size > 0) {
value += doubleQuote;
// Should this ever be a remote debugger, need to check byte order. // Should this ever be a remote debugger, need to check byte order.
unsigned short *buf = new unsigned short[size + 1]; unsigned short *buf = new unsigned short[size + 1];
unsigned long bytesRead; unsigned long bytesRead;
@@ -724,8 +725,13 @@ int CdbSymbolGroupContext::dumpQString(CIDebugDataSpaces *ds, WatchData *wd)
delete [] buf; delete [] buf;
if (truncated) if (truncated)
value += QLatin1String("..."); value += QLatin1String("...");
value += doubleQuote;
} else if (size == 0) {
value = QString(doubleQuote) + doubleQuote;
} else {
value = "Invalid QString";
} }
value += doubleQuote;
wd->setValue(value); wd->setValue(value);
wd->setHasChildren(false); wd->setHasChildren(false);
return 0; return 0;