feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Autotest: Simplify framework registration functions signature

Browse Source 
Change-Id: I249b73f0adf5a678145be9d00bee9a733097bfef
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-07-27 16:13:18 +02:00
parent c60f999a66
commit 8a6e4bea9e
2 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/autotest/testframeworkmanager.cpp
View File

@@ -25,22 +25,20 @@ TestFrameworkManager::~TestFrameworkManager()
s_instance = nullptr; s_instance = nullptr;
} }
bool TestFrameworkManager::registerTestFramework(ITestFramework *framework) void TestFrameworkManager::registerTestFramework(ITestFramework *framework)
{ {
QTC_ASSERT(framework, return false); QTC_ASSERT(framework, return);
QTC_ASSERT(!m_registeredFrameworks.contains(framework), return false); QTC_ASSERT(!m_registeredFrameworks.contains(framework), return);
// TODO check for unique priority before registering // TODO check for unique priority before registering
m_registeredFrameworks.append(framework); m_registeredFrameworks.append(framework);
Utils::sort(m_registeredFrameworks, &ITestFramework::priority); Utils::sort(m_registeredFrameworks, &ITestFramework::priority);
return true;
} }
bool TestFrameworkManager::registerTestTool(ITestTool *testTool) void TestFrameworkManager::registerTestTool(ITestTool *testTool)
{ {
QTC_ASSERT(testTool, return false); QTC_ASSERT(testTool, return);
QTC_ASSERT(!m_registeredTestTools.contains(testTool), return false); QTC_ASSERT(!m_registeredTestTools.contains(testTool), return);
m_registeredTestTools.append(testTool); m_registeredTestTools.append(testTool);
return true;
} }
void TestFrameworkManager::activateFrameworksAndToolsFromSettings() void TestFrameworkManager::activateFrameworksAndToolsFromSettings()

4
src/plugins/autotest/testframeworkmanager.h
View File

@@ -14,8 +14,8 @@ public:
TestFrameworkManager(); TestFrameworkManager();
~TestFrameworkManager(); ~TestFrameworkManager();
bool registerTestFramework(ITestFramework *framework); void registerTestFramework(ITestFramework *framework);
bool registerTestTool(ITestTool *testTool); void registerTestTool(ITestTool *testTool);
void synchronizeSettings(); void synchronizeSettings();
static ITestFramework *frameworkForId(Utils::Id frameworkId); static ITestFramework *frameworkForId(Utils::Id frameworkId);