From 8a72318c971cf4abc8ef187b7b200414d6bb1759 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 18 Sep 2023 13:36:39 +0200 Subject: [PATCH] OutputPane: Fix wrongly checked button with "Reset to Default" We only want to set the button "checked" if the Output panes are visible. Amends b72f9dc8ef96d2a39a141d5814fc1ecefcd2a231 Change-Id: Ia6fd461338086e141dac09ebf47de09c0635b28b Reviewed-by: Marcus Tillmanns --- src/plugins/coreplugin/outputpanemanager.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/plugins/coreplugin/outputpanemanager.cpp b/src/plugins/coreplugin/outputpanemanager.cpp index 4d8021acfb1..9ccbea0a0cc 100644 --- a/src/plugins/coreplugin/outputpanemanager.cpp +++ b/src/plugins/coreplugin/outputpanemanager.cpp @@ -789,7 +789,8 @@ void OutputPaneManager::popupMenu() for (int i = 0; i < g_outputPanes.size(); ++i) { OutputPaneData &data = g_outputPanes[i]; const bool buttonVisible = data.pane->priorityInStatusBar() >= 0; - const bool paneVisible = currentIndex() == i; + const bool paneVisible = currentIndex() == i + && OutputPanePlaceHolder::isCurrentVisible(); if (buttonVisible) { data.button->setChecked(paneVisible); data.button->setVisible(true);