feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DebuggerMainWindow: Avoid using keys()

Browse Source 
Instead, iterate directly over the container.

Change-Id: I13291bac9722ca87aa2f945342e04933c37d109f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2024-01-11 00:54:56 +01:00
parent 7c0b831391
commit 8ab7f1bd1d
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/debugger/debuggermainwindow.cpp
View File

@@ -435,17 +435,16 @@ void DebuggerMainWindow::restorePersistentSettings()
const QHash<QString, QVariant> states2 = settings->value(STATE_KEY2).toHash();
d->m_lastTypePerspectiveStates.clear();
QSet<QString> keys = Utils::toSet(states2.keys());
for (const QString &type : keys) {
for (auto it = states2.begin(); it != states2.end(); ++it) {
PerspectiveState state;
if (states2.value(type).canConvert<QVariantMap>()) {
state = PerspectiveState::fromSettings(storeFromMap(states2.value(type).toMap()));
if (it->canConvert<QVariantMap>()) {
state = PerspectiveState::fromSettings(storeFromMap(it->toMap()));
} else {
// legacy for up to QtC 12
state = states2.value(type).value<PerspectiveState>();
state = it->value<PerspectiveState>();
}
QTC_ASSERT(state.hasWindowState(), continue);
d->m_lastTypePerspectiveStates.insert(type, state);
d->m_lastTypePerspectiveStates.insert(it.key(), state);
}
showCentralWidget(settings->value(SHOW_CENTRALWIDGET_KEY, true).toBool());