From 8ae55344de7db3e29917cee4137af1e5dd68e3eb Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Wed, 3 Aug 2022 14:27:18 +0200
Subject: [PATCH] ClangCodemodel: Avoid repeated construction of category
 prefixes

Change-Id: I0166010a17f1f37855862f28cc9e2472b638c9de
Reviewed-by: David Schulz <david.schulz@qt.io>
---
 src/plugins/clangcodemodel/clangutils.cpp | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/plugins/clangcodemodel/clangutils.cpp b/src/plugins/clangcodemodel/clangutils.cpp
index c85ee98e1cf..b98ad7e91be 100644
--- a/src/plugins/clangcodemodel/clangutils.cpp
+++ b/src/plugins/clangcodemodel/clangutils.cpp
@@ -76,15 +76,14 @@ QString diagnosticCategoryPrefixRemoved(const QString &text)
     // Prefixes are taken from $LLVM_SOURCE_DIR/tools/clang/lib/Frontend/TextDiagnostic.cpp,
     // function TextDiagnostic::printDiagnosticLevel (llvm-3.6.2).
     static const QStringList categoryPrefixes = {
-        QStringLiteral("note"),
-        QStringLiteral("remark"),
-        QStringLiteral("warning"),
-        QStringLiteral("error"),
-        QStringLiteral("fatal error")
+        QStringLiteral("note: "),
+        QStringLiteral("remark: "),
+        QStringLiteral("warning: "),
+        QStringLiteral("error: "),
+        QStringLiteral("fatal error: ")
     };
 
-    for (const QString &prefix : categoryPrefixes) {
-        const QString fullPrefix = prefix + QStringLiteral(": ");
+    for (const QString &fullPrefix : categoryPrefixes) {
         if (theText.startsWith(fullPrefix)) {
             theText.remove(0, fullPrefix.length());
             return theText;