From 8b87f8f0b705ad788c997b42c4a0f51bd028326c Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 3 May 2024 11:05:16 +0200 Subject: [PATCH] Android: Pass const reference instead of a copy Change-Id: I5058478c99b6316c836003239490c606ca0efb4b Reviewed-by: Alessandro Portale --- src/plugins/android/androidrunnerworker.cpp | 4 ++-- src/plugins/android/androidrunnerworker.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/android/androidrunnerworker.cpp b/src/plugins/android/androidrunnerworker.cpp index a0169c6bfb2..34688de9a17 100644 --- a/src/plugins/android/androidrunnerworker.cpp +++ b/src/plugins/android/androidrunnerworker.cpp @@ -83,7 +83,7 @@ static qint64 extractPID(const QString &output, const QString &packageName) } static void findProcessPIDAndUser(QPromise &promise, - QStringList selector, + const QStringList &selector, const QString &packageName, bool preNougat) { @@ -821,7 +821,7 @@ void AndroidRunnerWorker::removeForwardPort(const QString &port) } } -void AndroidRunnerWorker::onProcessIdChanged(PidUserPair pidUser) +void AndroidRunnerWorker::onProcessIdChanged(const PidUserPair &pidUser) { // Don't write to m_psProc from a different thread QTC_ASSERT(QThread::currentThread() == thread(), return); diff --git a/src/plugins/android/androidrunnerworker.h b/src/plugins/android/androidrunnerworker.h index 052fe2812cb..ac995fe1627 100644 --- a/src/plugins/android/androidrunnerworker.h +++ b/src/plugins/android/androidrunnerworker.h @@ -75,7 +75,7 @@ private: Waiting, Settled }; - void onProcessIdChanged(PidUserPair pidUser); + void onProcessIdChanged(const PidUserPair &pidUser); // Create the processes and timer in the worker thread, for correct thread affinity bool m_isPreNougat = false;