From 8bc6cf3f9824dedefc2c5a249e18194fa4f187ba Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 11 Jul 2022 10:25:50 +0200 Subject: [PATCH] Fix the runtime warning when building against Qt 5 It fixes the following warning: QObject::connect: Cannot queue arguments of type 'FilePath' (Make sure 'FilePath' is registered using qRegisterMetaType().) It looks like with Qt 5 all arguments needs to be specified with full namespace in order to be used in queued connections. Note, that warning is misleading as adding qRegisterMetaType() doesn't fix it in this case. The full scope isn't needed when building against Qt 6, so leaving a TODO for Creator 9.0 Change-Id: I43a52385b8d3bb0ef90ce274e11df9fd68e62109 Reviewed-by: Reviewed-by: hjk --- src/libs/utils/shellcommand.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libs/utils/shellcommand.h b/src/libs/utils/shellcommand.h index 394df03866a..f4ab789079b 100644 --- a/src/libs/utils/shellcommand.h +++ b/src/libs/utils/shellcommand.h @@ -149,7 +149,8 @@ signals: void append(const QString &text); void appendSilently(const QString &text); void appendError(const QString &text); - void appendCommand(const FilePath &workingDirectory, const CommandLine &command); + // TODO: remove Utils:: scope when support for Qt5 is dropped (Creator 9.0) + void appendCommand(const Utils::FilePath &workingDirectory, const Utils::CommandLine &command); void appendMessage(const QString &text); protected: