feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CodeAssist: Fix leaking asynchronous processors

Browse Source 
Currently the ownership of the processor is unknown to the codeassist
when running an async operation. Move the ownership of the processor to
the assist and delete the processor after the proposal was completed.

Change-Id: I6a2e023c47cbc876669dba866bee12b481447cb7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2020-03-26 09:21:57 +01:00
parent da3b14faee
commit 8bde432dfe
7 changed files with 36 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/languageclient/languageclientfunctionhint.cpp
View File

@@ -96,6 +96,7 @@ void FunctionHintProcessor::cancel()
{
if (running()) {
m_client->cancelRequest(m_currentRequest);
m_client->removeAssistProcessor(this);
m_currentRequest = MessageId();
}
}
@@ -107,6 +108,7 @@ void FunctionHintProcessor::handleSignatureResponse(const SignatureHelpRequest::
m_client->log(error.value());
FunctionHintProposalModelPtr model(
new FunctionHintProposalModel(response.result().value().value()));
m_client->removeAssistProcessor(this);
setAsyncProposalAvailable(new FunctionHintProposal(m_pos, model));
}