feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

debugger: remove "quick shot" on stop.

Browse Source 
This was used to enhance the user experience in the gdb/MI (non-python)
days as the location marker was shown faster. This does not seem to
make much of a difference anymore. Removal also avoids the "show disassembly
first, source next" flicker.
This commit is contained in:
hjk
2010-11-19 08:50:53 +01:00
parent c2f5300798
commit 8bebbddb3a
1 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -1432,19 +1432,9 @@ void GdbEngine::handleStop1(const GdbMi &data)
m_currentFrame = _(gdbmiFrame.findChild("addr").data() + '%' +
gdbmiFrame.findChild("func").data() + '%');
// Quick shot: Jump to stack frame #0.
StackFrame frame;
if (gdbmiFrame.isValid()) {
frame = parseStackFrame(gdbmiFrame, 0);
gotoLocation(frame, true);
}
//
// Stack
//
stackHandler()->setCurrentIndex(0);
updateLocals(qVariantFromValue(frame)); // Quick shot
reloadStack(false);
if (supportsThreads()) {
@@ -3010,15 +3000,8 @@ void GdbEngine::handleStackListFrames(const GdbResponse &response)
if (targetFrame == -1)
targetFrame = 0;
// Mac gdb does not add the location to the "stopped" message,
// so the early gotoLocation() was not triggered. Force it here.
// For targetFrame == 0 we already issued a 'gotoLocation'
// when reading the *stopped message.
bool jump = (m_isMacGdb || targetFrame != 0);
stackHandler()->setCurrentIndex(targetFrame);
if (jump || cookie.gotoLocation)
activateFrame(targetFrame);
activateFrame(targetFrame);
}
void GdbEngine::activateFrame(int frameIndex)