From 8c8f3e30b56175967c5fb91b0cde89c7f66dc75c Mon Sep 17 00:00:00 2001 From: David Schulz Date: Tue, 6 Dec 2022 09:47:18 +0100 Subject: [PATCH] LanguageClient: Fix handling of defective language server If the language server cannot be started, the client might be already in an error state before the language server gets initialized. Change-Id: Ib6c9df13b381e7854806714c07f4830796bb2cd3 Reviewed-by: Marcus Tillmanns Reviewed-by: Christian Stenger --- src/plugins/languageclient/languageclientmanager.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/languageclient/languageclientmanager.cpp b/src/plugins/languageclient/languageclientmanager.cpp index 60468ff12de..7f50391ea1f 100644 --- a/src/plugins/languageclient/languageclientmanager.cpp +++ b/src/plugins/languageclient/languageclientmanager.cpp @@ -113,6 +113,8 @@ void LanguageClientManager::clientStarted(Client *client) qCDebug(Log) << "client started: " << client->name() << client; QTC_ASSERT(managerInstance, return); QTC_ASSERT(client, return); + if (client->state() != Client::Uninitialized) // do not proceed if we already received an error + return; if (g_shuttingDown) { clientFinished(client); return;