feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Help: Remove unnecessary QLatin1Strings

Browse Source 
Change-Id: Ia5c83d5e2c392873f400f3db396b9c355cdd4192
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Eike Ziller
2016-07-20 10:11:35 +02:00
parent c512f5d71f
commit 8c94419a0b
14 changed files with 126 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/help/docsettingspage.cpp
View File

@@ -134,7 +134,7 @@ DocSettingsPage::DocSettingsPage()
setDisplayName(tr("Documentation"));
setCategory(Help::Constants::HELP_CATEGORY);
setDisplayCategory(QCoreApplication::translate("Help", Help::Constants::HELP_TR_CATEGORY));
setCategoryIcon(QLatin1String(Help::Constants::HELP_CATEGORY_ICON));
setCategoryIcon(Help::Constants::HELP_CATEGORY_ICON);
}
QWidget *DocSettingsPage::widget()
@@ -189,8 +189,7 @@ void DocSettingsPage::addDocumentation()
const QString filePath = QDir::cleanPath(file);
const QString &nameSpace = HelpManager::namespaceFromFile(filePath);
if (nameSpace.isEmpty()) {
docsUnableToRegister.insertMulti(QLatin1String("UnknownNamespace"),
QDir::toNativeSeparators(filePath));
docsUnableToRegister.insertMulti("UnknownNamespace", QDir::toNativeSeparators(filePath));
continue;
}
@@ -222,12 +221,12 @@ void DocSettingsPage::addDocumentation()
}
QString formatedFail;
if (docsUnableToRegister.contains(QLatin1String("UnknownNamespace"))) {
if (docsUnableToRegister.contains("UnknownNamespace")) {
formatedFail += QString::fromLatin1("<ul><li><b>%1</b>").arg(tr("Invalid documentation file:"));
foreach (const QString &value, docsUnableToRegister.values(QLatin1String("UnknownNamespace")))
foreach (const QString &value, docsUnableToRegister.values("UnknownNamespace"))
formatedFail += QString::fromLatin1("<ul><li>%2</li></ul>").arg(value);
formatedFail += QLatin1String("</li></ul>");
docsUnableToRegister.remove(QLatin1String("UnknownNamespace"));
formatedFail += "</li></ul>";
docsUnableToRegister.remove("UnknownNamespace");
}
if (!docsUnableToRegister.isEmpty()) {
@@ -236,7 +235,7 @@ void DocSettingsPage::addDocumentation()
for (NameSpaceToPathHash::ConstIterator it = docsUnableToRegister.constBegin(); it != cend; ++it) {
formatedFail += QString::fromLatin1("<ul><li>%1 - %2</li></ul>").arg(it.key(), it.value());
}
formatedFail += QLatin1String("</li></ul>");
formatedFail += "</li></ul>";
}
if (!formatedFail.isEmpty()) {