feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Make sure to call FileSaver::finalize

Browse Source 
We may leak resources otherwise.

Change-Id: Ic09f58bd47cbf283e22f17f2c3393ca03c5dfacf
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
This commit is contained in:
Tobias Hunger
2013-06-04 18:01:47 +02:00
parent c6cbc97a5c
commit 8cd56cf68d
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/libs/utils/textfileformat.cpp
View File

@@ -289,13 +289,11 @@ bool TextFileFormat::writeFile(const QString &fileName, QString plainText, QStri
} }
Utils::FileSaver saver(fileName, fileMode); Utils::FileSaver saver(fileName, fileMode);
if (saver.hasError()) { if (!saver.hasError()) {
*errorString = saver.errorString(); if (hasUtf8Bom && codec->name() == "UTF-8")
return false; saver.write("\xef\xbb\xbf", 3);
saver.write(codec->fromUnicode(plainText));
} }
if (hasUtf8Bom && codec->name() == "UTF-8")
saver.write("\xef\xbb\xbf", 3);
saver.write(codec->fromUnicode(plainText));
const bool ok = saver.finalize(errorString); const bool ok = saver.finalize(errorString);
if (debug) if (debug)
qDebug().nospace() << Q_FUNC_INFO << fileName << ' ' << *this << ' ' << plainText.size() qDebug().nospace() << Q_FUNC_INFO << fileName << ' ' << *this << ' ' << plainText.size()