From 8d2858d8fe66125277f8bc83fa671914e706df51 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Mon, 14 Mar 2016 13:10:19 +0100 Subject: [PATCH] CodeAssist: Initialize locals and member after early return. Change-Id: Iec850ccbb6461b581fd2347006e6dfc8a0b605a7 Reviewed-by: Christian Stenger --- src/plugins/texteditor/codeassist/codeassistant.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/plugins/texteditor/codeassist/codeassistant.cpp b/src/plugins/texteditor/codeassist/codeassistant.cpp index 45f78324b8e..f83b5e855d9 100644 --- a/src/plugins/texteditor/codeassist/codeassistant.cpp +++ b/src/plugins/texteditor/codeassist/codeassistant.cpp @@ -223,13 +223,12 @@ void CodeAssistantPrivate::requestProposal(AssistReason reason, return; } + AssistInterface *assistInterface = m_editorWidget->createAssistInterface(kind, reason); + if (!assistInterface) + return; + m_assistKind = kind; IAssistProcessor *processor = provider->createProcessor(); - AssistInterface *assistInterface = m_editorWidget->createAssistInterface(kind, reason); - if (!assistInterface) { - delete processor; - return; - } switch (provider->runType()) { case IAssistProvider::Synchronous: {