feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Rename PathChooser::changed() signal.

Browse Source 
The name is overly generic, particularly with a pathChanged() signal
also present. Rename to "rawPathChanged", which adequately describes the
semantics.

Change-Id: Ia62b8b0a97a794cb6d5ad6b8ce0abcd36b5f5cdb
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This commit is contained in:
Christian Kandeler
2015-08-20 14:56:30 +02:00
parent c2ef849997
commit 8d3aa026e0
36 changed files with 54 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libs/utils/pathchooser.cpp
View File

@@ -228,7 +228,8 @@ PathChooser::PathChooser(QWidget *parent) :
connect(d->m_lineEdit, &FancyLineEdit::customContextMenuRequested, this, &PathChooser::contextMenuRequested);
connect(d->m_lineEdit, &FancyLineEdit::validReturnPressed, this, &PathChooser::returnPressed);
connect(d->m_lineEdit, &QLineEdit::textChanged, this, [this] { emit changed(rawPath()); });
connect(d->m_lineEdit, &QLineEdit::textChanged, this,
[this] { emit rawPathChanged(rawPath()); });
connect(d->m_lineEdit, &FancyLineEdit::validChanged, this, &PathChooser::validChanged);
connect(d->m_lineEdit, &QLineEdit::editingFinished, this, &PathChooser::editingFinished);
connect(d->m_lineEdit, &QLineEdit::textChanged, this, [this] { emit pathChanged(path()); });
@@ -306,7 +307,7 @@ void PathChooser::setEnvironment(const Environment &env)
d->m_environment = env;
if (path() != oldExpand) {
triggerChanged();
emit changed(rawPath());
emit rawPathChanged(rawPath());
}
}