feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Do not reuse RemoteAdditionDialog

Browse Source 
There's no reason.

Move it to the cpp file while at it.

Change-Id: I365443fa58db278777ec2f06ea172e9f91992287
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Orgad Shaneh
2017-03-04 22:03:02 +02:00
committed by Orgad Shaneh
parent 861d30cf68
commit 8d5e8f6874
2 changed files with 22 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
src/plugins/git/remotedialog.cpp
View File

@@ -43,34 +43,29 @@ namespace Internal {
// RemoteAdditionDialog:
// --------------------------------------------------------------------------
RemoteAdditionDialog::RemoteAdditionDialog(QWidget *parent) :
QDialog(parent),
m_ui(new Ui::RemoteAdditionDialog)
class RemoteAdditionDialog : public QDialog
{
m_ui->setupUi(this);
setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
}
public:
RemoteAdditionDialog()
{
m_ui.setupUi(this);
setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
}
RemoteAdditionDialog::~RemoteAdditionDialog()
{
delete m_ui;
}
QString remoteName() const
{
return m_ui.nameEdit->text();
}
QString RemoteAdditionDialog::remoteName() const
{
return m_ui->nameEdit->text();
}
QString remoteUrl() const
{
return m_ui.urlEdit->text();
}
QString RemoteAdditionDialog::remoteUrl() const
{
return m_ui->urlEdit->text();
}
private:
Ui::RemoteAdditionDialog m_ui;
};
void RemoteAdditionDialog::clear()
{
m_ui->nameEdit->clear();
m_ui->urlEdit->clear();
}
// --------------------------------------------------------------------------
// RemoteDialog:
@@ -130,14 +125,11 @@ void RemoteDialog::refreshRemotes()
void RemoteDialog::addRemote()
{
if (!m_addDialog)
m_addDialog = new RemoteAdditionDialog;
m_addDialog->clear();
if (m_addDialog->exec() != QDialog::Accepted)
RemoteAdditionDialog addDialog;
if (addDialog.exec() != QDialog::Accepted)
return;
m_remoteModel->addRemote(m_addDialog->remoteName(), m_addDialog->remoteUrl());
m_remoteModel->addRemote(addDialog.remoteName(), addDialog.remoteUrl());
}
void RemoteDialog::removeRemote()