From 8d6cb35b745176604330b9663f3ef551e87e7f3c Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 19 Mar 2021 14:46:09 +0100 Subject: [PATCH] Git: Remove note in settings dialog that does not apply anymore Change-Id: I54e86ad419c09acc7ebd15bb4b2660d159c410f0 Reviewed-by: Orgad Shaneh --- src/plugins/git/gitsettings.cpp | 12 ------------ src/plugins/git/gitsettings.h | 1 - 2 files changed, 13 deletions(-) diff --git a/src/plugins/git/gitsettings.cpp b/src/plugins/git/gitsettings.cpp index 8a16b905a96..874fb4828d7 100644 --- a/src/plugins/git/gitsettings.cpp +++ b/src/plugins/git/gitsettings.cpp @@ -132,18 +132,6 @@ GitSettings::GitSettings() refLogShowDate.setSettingsKey("RefLogShowDate"); timeout.setDefaultValue(Utils::HostOsInfo::isWindowsHost() ? 60 : 30); - - note.setText(tr("Note:") + tr("Git needs to find Perl in the environment.")); - - const auto updateNoteField = [this] { - Environment env = Environment::systemEnvironment(); - env.prependOrSetPath(path.value()); - const bool showNote = env.searchInPath("perl").isEmpty(); - note.setVisible(showNote); - }; - - updateNoteField(); - QObject::connect(&path, &BaseAspect::changed, ¬e, updateNoteField); } FilePath GitSettings::gitExecutable(bool *ok, QString *errorMessage) const diff --git a/src/plugins/git/gitsettings.h b/src/plugins/git/gitsettings.h index c9917916637..5e06c52f46c 100644 --- a/src/plugins/git/gitsettings.h +++ b/src/plugins/git/gitsettings.h @@ -63,7 +63,6 @@ public: Utils::BoolAspect followRenames; Utils::IntegerAspect lastResetIndex; Utils::BoolAspect refLogShowDate; - Utils::TextDisplay note; Utils::FilePath gitExecutable(bool *ok = nullptr, QString *errorMessage = nullptr) const; };