feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Delete dialogbox => avoid memory leak

Browse Source 
Change-Id: I0f6eba4366f7760bfafd201e6ac22b23b11ce61c
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Montel Laurent
2017-02-20 17:37:32 +01:00
committed by Laurent Montel
parent dce4f03fc3
commit 8d7feb4bc7
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/todo/optionsdialog.cpp
View File

@@ -98,9 +98,9 @@ Settings OptionsDialog::settings()
void OptionsDialog::addKeywordButtonClicked()
{
Keyword keyword;
KeywordDialog *keywordDialog = new KeywordDialog(keyword, keywordNames(), this);
if (keywordDialog->exec() == QDialog::Accepted) {
keyword = keywordDialog->keyword();
KeywordDialog keywordDialog(keyword, keywordNames(), this);
if (keywordDialog.exec() == QDialog::Accepted) {
keyword = keywordDialog.keyword();
addToKeywordsList(keyword);
}
}
@@ -121,9 +121,9 @@ void OptionsDialog::editKeyword(QListWidgetItem *item)
QSet<QString> keywordNamesButThis = keywordNames();
keywordNamesButThis.remove(keyword.name);
KeywordDialog *keywordDialog = new KeywordDialog(keyword, keywordNamesButThis, this);
if (keywordDialog->exec() == QDialog::Accepted) {
keyword = keywordDialog->keyword();
KeywordDialog keywordDialog(keyword, keywordNamesButThis, this);
if (keywordDialog.exec() == QDialog::Accepted) {
keyword = keywordDialog.keyword();
item->setIcon(icon(keyword.iconType));
item->setText(keyword.name);
item->setData(Qt::UserRole, static_cast<int>(keyword.iconType));