feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Restructure cleaning up after test

Browse Source 
If the test case would result in a failing test it does not
execute further commands.
Ensure to close possible open editors even for failed test runs.

Change-Id: Ifcdcb76de5d10f649d38b84dad8999c6fd491ade
Reviewed-by: hjk <hjk@theqtcompany.com>
This commit is contained in:
Christian Stenger
2016-05-18 07:33:52 +02:00
parent 3c63b621d9
commit 8daaa2f651
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/debugger/debuggerplugin.cpp
View File

@@ -163,6 +163,8 @@
#include <cpptools/cpptoolstestcase.h> #include <cpptools/cpptoolstestcase.h>
#include <cpptools/projectinfo.h> #include <cpptools/projectinfo.h>
#include <utils/executeondestruction.h>
#include <QTest> #include <QTest>
#include <QSignalSpy> #include <QSignalSpy>
#include <QTestEventLoop> #include <QTestEventLoop>
@@ -3675,6 +3677,9 @@ void DebuggerUnitTests::testStateMachine()
ProjectExplorerPlugin::buildProject(SessionManager::startupProject()); ProjectExplorerPlugin::buildProject(SessionManager::startupProject());
loop.exec(); loop.exec();
ExecuteOnDestruction guard([] () {
EditorManager::closeAllEditors(false);
});
DebuggerRunParameters rp; DebuggerRunParameters rp;
Target *t = SessionManager::startupProject()->activeTarget(); Target *t = SessionManager::startupProject()->activeTarget();
QVERIFY(t); QVERIFY(t);
@@ -3691,7 +3696,6 @@ void DebuggerUnitTests::testStateMachine()
}); });
QTestEventLoop::instance().enterLoop(5); QTestEventLoop::instance().enterLoop(5);
EditorManager::closeAllEditors(false);
} }