diff --git a/src/plugins/android/CMakeLists.txt b/src/plugins/android/CMakeLists.txt index abb7ea92677..c7802e1527e 100644 --- a/src/plugins/android/CMakeLists.txt +++ b/src/plugins/android/CMakeLists.txt @@ -18,7 +18,6 @@ add_qtc_plugin(Android androidmanager.cpp androidmanager.h androidmanifestdocument.cpp androidmanifestdocument.h androidmanifesteditor.cpp androidmanifesteditor.h - androidmanifesteditorfactory.cpp androidmanifesteditorfactory.h androidmanifesteditorwidget.cpp androidmanifesteditorwidget.h androidmanifesteditoriconwidget.cpp androidmanifesteditoriconwidget.h androidmanifesteditoriconcontainerwidget.cpp androidmanifesteditoriconcontainerwidget.h diff --git a/src/plugins/android/android.qbs b/src/plugins/android/android.qbs index 18d466ba153..92a420c8efa 100644 --- a/src/plugins/android/android.qbs +++ b/src/plugins/android/android.qbs @@ -46,8 +46,6 @@ QtcPlugin { "androidmanifesteditoriconwidget.h", "androidmanifesteditoriconcontainerwidget.cpp", "androidmanifesteditoriconcontainerwidget.h", - "androidmanifesteditorfactory.cpp", - "androidmanifesteditorfactory.h", "androidmanifesteditorwidget.cpp", "androidmanifesteditorwidget.h", "androidpackageinstallationstep.cpp", diff --git a/src/plugins/android/androidmanifesteditor.cpp b/src/plugins/android/androidmanifesteditor.cpp index a2bbdf2f9a5..cdbf248d78d 100644 --- a/src/plugins/android/androidmanifesteditor.cpp +++ b/src/plugins/android/androidmanifesteditor.cpp @@ -13,8 +13,7 @@ #include #include -using namespace Android; -using namespace Internal; +namespace Android::Internal { AndroidManifestEditor::AndroidManifestEditor(AndroidManifestEditorWidget *editorWidget) : m_toolBar(nullptr) @@ -87,3 +86,27 @@ void AndroidManifestEditor::changeEditorPage(QAction *action) } } } + +// Factory + +class AndroidManifestEditorFactory final : public Core::IEditorFactory +{ +public: + AndroidManifestEditorFactory() + { + setId(Constants::ANDROID_MANIFEST_EDITOR_ID); + setDisplayName(Tr::tr("Android Manifest editor")); + addMimeType(Constants::ANDROID_MANIFEST_MIME_TYPE); + setEditorCreator([] { + auto androidManifestEditorWidget = new AndroidManifestEditorWidget; + return androidManifestEditorWidget->editor(); + }); + } +}; + +void setupAndroidManifestEditor() +{ + static AndroidManifestEditorFactory theAndroidManifestEditorFactory; +} + +} // Android::Internal diff --git a/src/plugins/android/androidmanifesteditor.h b/src/plugins/android/androidmanifesteditor.h index 0a6ab678988..9583d7e0f99 100644 --- a/src/plugins/android/androidmanifesteditor.h +++ b/src/plugins/android/androidmanifesteditor.h @@ -14,8 +14,7 @@ class QToolBar; class QActionGroup; QT_END_NAMESPACE -namespace Android { -namespace Internal { +namespace Android::Internal { class AndroidManifestEditor : public Core::IEditor { @@ -41,5 +40,6 @@ private: QActionGroup *m_actionGroup; }; -} // namespace Internal -} // namespace Android +void setupAndroidManifestEditor(); + +} // Android::Internal diff --git a/src/plugins/android/androidmanifesteditorfactory.cpp b/src/plugins/android/androidmanifesteditorfactory.cpp deleted file mode 100644 index 41d6af0861d..00000000000 --- a/src/plugins/android/androidmanifesteditorfactory.cpp +++ /dev/null @@ -1,37 +0,0 @@ -// Copyright (C) 2016 The Qt Company Ltd. -// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 - -#include "androidconstants.h" -#include "androidmanifesteditor.h" -#include "androidmanifesteditorfactory.h" -#include "androidmanifesteditorwidget.h" -#include "androidtr.h" - -#include - -#include - -namespace Android::Internal { - -class AndroidManifestEditorFactory final : public Core::IEditorFactory -{ -public: - AndroidManifestEditorFactory() - { - setId(Constants::ANDROID_MANIFEST_EDITOR_ID); - setDisplayName(Tr::tr("Android Manifest editor")); - addMimeType(Constants::ANDROID_MANIFEST_MIME_TYPE); - setEditorCreator([] { - auto androidManifestEditorWidget = new AndroidManifestEditorWidget; - return androidManifestEditorWidget->editor(); - }); - } -}; - -void setupAndroidManifestEditor() -{ - static AndroidManifestEditorFactory theAndroidManifestEditorFactory; -} - -} // Android::Internal - diff --git a/src/plugins/android/androidmanifesteditorfactory.h b/src/plugins/android/androidmanifesteditorfactory.h deleted file mode 100644 index fe812fd94a6..00000000000 --- a/src/plugins/android/androidmanifesteditorfactory.h +++ /dev/null @@ -1,10 +0,0 @@ -// Copyright (C) 2016 The Qt Company Ltd. -// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 - -#pragma once - -namespace Android::Internal { - -void setupAndroidManifestEditor(); - -} // Android::Internal diff --git a/src/plugins/android/androidmanifesteditorwidget.cpp b/src/plugins/android/androidmanifesteditorwidget.cpp index 049cd67404d..d0a44730662 100644 --- a/src/plugins/android/androidmanifesteditorwidget.cpp +++ b/src/plugins/android/androidmanifesteditorwidget.cpp @@ -1414,4 +1414,6 @@ AndroidManifestTextEditorWidget::AndroidManifestTextEditorWidget(AndroidManifest Core::ICore::addContextObject(m_context); } + + } // Android::Internal diff --git a/src/plugins/android/androidplugin.cpp b/src/plugins/android/androidplugin.cpp index 6a1b66a2f35..5f860134f8f 100644 --- a/src/plugins/android/androidplugin.cpp +++ b/src/plugins/android/androidplugin.cpp @@ -7,7 +7,7 @@ #include "androiddebugsupport.h" #include "androiddeployqtstep.h" #include "androiddevice.h" -#include "androidmanifesteditorfactory.h" +#include "androidmanifesteditor.h" #include "androidpackageinstallationstep.h" #include "androidpotentialkit.h" #include "androidqmltoolingsupport.h"