feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

mostly core and analyzer: more id-fication

Browse Source 
Change-Id: Ic794fdc6a582f4a03d84b6220c59111044c753b9
Reviewed-by: hjk <qthjk@ovi.com>
This commit is contained in:
hjk
2011-11-11 12:16:20 +01:00
committed by hjk
parent ead4674646
commit 8e236db9f5
28 changed files with 152 additions and 202 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/valgrind/callgrindtool.cpp
View File

@@ -513,7 +513,7 @@ CallgrindTool::~CallgrindTool()
delete d;
}
QByteArray CallgrindTool::id() const
Core::Id CallgrindTool::id() const
{
return "Callgrind";
}

2
src/plugins/valgrind/callgrindtool.h
View File

@@ -48,7 +48,7 @@ public:
CallgrindTool(QObject *parent);
~CallgrindTool();
QByteArray id() const;
Core::Id id() const;
QString displayName() const;
QString description() const;
ToolMode toolMode() const;

2
src/plugins/valgrind/memchecktool.cpp
View File

@@ -285,7 +285,7 @@ void MemcheckTool::maybeActiveRunConfigurationChanged()
m_errorProxyModel->setFilterExternalIssues(memcheckSettings->filterExternalIssues());
}
QByteArray MemcheckTool::id() const
Core::Id MemcheckTool::id() const
{
return "Memcheck";
}

2
src/plugins/valgrind/memchecktool.h
View File

@@ -93,7 +93,7 @@ class MemcheckTool : public Analyzer::IAnalyzerTool
public:
MemcheckTool(QObject *parent);
QByteArray id() const;
Core::Id id() const;
QString displayName() const;
QString description() const;

4
src/plugins/valgrind/valgrindplugin.cpp
View File

@@ -128,7 +128,7 @@ RunControl *ValgrindRunControlFactory::create(RunConfiguration *runConfiguration
sp.startMode = StartRemote;
}
IAnalyzerTool *tool = AnalyzerManager::toolFromId(mode.toLatin1());
IAnalyzerTool *tool = AnalyzerManager::toolFromId(Core::Id(mode));
AnalyzerRunControl *rc = new AnalyzerRunControl(tool, sp, runConfiguration);
QObject::connect(AnalyzerManager::stopAction(), SIGNAL(triggered()), rc, SLOT(stopIt()));
return rc;
@@ -185,7 +185,7 @@ static void startRemoteTool(IAnalyzerTool *tool, StartMode mode)
//m_currentRunControl = rc;
QObject::connect(AnalyzerManager::stopAction(), SIGNAL(triggered()), rc, SLOT(stopIt()));
ProjectExplorerPlugin::instance()->startRunControl(rc, tool->id());
ProjectExplorerPlugin::instance()->startRunControl(rc, tool->id().toString());
}
void ValgrindPlugin::startValgrindTool(IAnalyzerTool *tool, StartMode mode)