feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsCommand: Some cleanup

Browse Source 
Remove unused include. Remove outdated comments.

Change-Id: Idcdb5f3ad06b0d40c03c3cd601d8a4b926474c3c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-10-11 18:19:38 +02:00
parent eb8b8eea41
commit 8e4cdf2a69
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/vcsbase/vcscommand.cpp
View File

@@ -7,7 +7,6 @@
#include "vcsoutputwindow.h" #include "vcsoutputwindow.h"
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
#include <coreplugin/progressmanager/progressmanager.h>
#include <utils/environment.h> #include <utils/environment.h>
#include <utils/globalfilechangeblocker.h> #include <utils/globalfilechangeblocker.h>
@@ -103,7 +102,6 @@ void VcsCommandPrivate::cleanup()
void VcsCommandPrivate::setupProcess(QtcProcess *process, const Job &job) void VcsCommandPrivate::setupProcess(QtcProcess *process, const Job &job)
{ {
process->setExitCodeInterpreter(job.exitCodeInterpreter); process->setExitCodeInterpreter(job.exitCodeInterpreter);
// TODO: Handle it properly in QtcProcess when QtcProcess::runBlocking() isn't used.
process->setTimeoutS(job.timeoutS); process->setTimeoutS(job.timeoutS);
if (!job.workingDirectory.isEmpty()) if (!job.workingDirectory.isEmpty())
process->setWorkingDirectory(job.workingDirectory); process->setWorkingDirectory(job.workingDirectory);
@@ -140,7 +138,6 @@ void VcsCommandPrivate::installStdCallbacks(QtcProcess *process)
emit q->stdErrText(text); emit q->stdErrText(text);
}); });
} }
// connect stdout to the output window if desired
if (m_progressParser || m_flags & RunFlags::ProgressiveOutput if (m_progressParser || m_flags & RunFlags::ProgressiveOutput
|| m_flags & RunFlags::ShowStdOut) { || m_flags & RunFlags::ShowStdOut) {
process->setTextChannelMode(Channel::Output, TextChannelMode::MultiLine); process->setTextChannelMode(Channel::Output, TextChannelMode::MultiLine);
@@ -155,8 +152,6 @@ void VcsCommandPrivate::installStdCallbacks(QtcProcess *process)
emit q->stdOutText(text); emit q->stdOutText(text);
}); });
} }
// TODO: Implement it here
// m_process->setTimeOutMessageBoxEnabled(true);
} }
EventLoopMode VcsCommandPrivate::eventLoopMode() const EventLoopMode VcsCommandPrivate::eventLoopMode() const
@@ -216,7 +211,6 @@ void VcsCommandPrivate::processDone()
} }
emit q->done(); emit q->done();
cleanup(); cleanup();
// As it is used asynchronously, we need to delete ourselves
q->deleteLater(); q->deleteLater();
} }
@@ -325,7 +319,6 @@ void VcsCommand::setCodec(QTextCodec *codec)
d->m_codec = codec; d->m_codec = codec;
} }
//! Use \a parser to parse progress data from stdout. Command takes ownership of \a parser
void VcsCommand::setProgressParser(const ProgressParser &parser) void VcsCommand::setProgressParser(const ProgressParser &parser)
{ {
d->m_progressParser = parser; d->m_progressParser = parser;